Skip to content

Commit 263b953

Browse files
committed
be_true -> be_truthy, be_false -> be_falsey
1 parent 48b24d4 commit 263b953

File tree

7 files changed

+26
-26
lines changed

7 files changed

+26
-26
lines changed

features/controller_specs/anonymous_controller.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ Feature: anonymous controller
144144
it "invokes the callback" do
145145
get :index
146146
147-
expect(assigns[:callback_invoked]).to be_true
147+
expect(assigns[:callback_invoked]).to be_truthy
148148
end
149149
end
150150
"""

features/mocks/mock_model.feature

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ Feature: mock_model
1818
1919
describe "mock_model('Car') with no Car constant in existence" do
2020
it "generates a constant" do
21-
expect(Object.const_defined?(:Car)).to be_false
21+
expect(Object.const_defined?(:Car)).to be_falsey
2222
mock_model("Car")
23-
expect(Object.const_defined?(:Car)).to be_true
23+
expect(Object.const_defined?(:Car)).to be_truthy
2424
end
2525
2626
describe "generates an object that ..." do
@@ -115,7 +115,7 @@ Feature: mock_model
115115
116116
it "supports stubs for methods that do exist" do
117117
expect(widget.save).to eq(true)
118-
expect(widget.update_attributes).to be_false
118+
expect(widget.update_attributes).to be_falsey
119119
end
120120
121121
describe "#errors" do

features/mocks/stub_model.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Feature: stub_model
2121
end
2222
2323
it "stubs :random_attribute" do
24-
expect(widget.random_attribute).to be_true
24+
expect(widget.random_attribute).to be_truthy
2525
end
2626
2727
it "returns false for new_record? if :id is set" do

spec/rspec/rails/configuration_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
describe "#render_views?" do
1313
it "is false by default" do
14-
RSpec.configuration.render_views?.should be_false
14+
RSpec.configuration.render_views?.should be_falsey
1515
end
1616
end
1717

@@ -20,7 +20,7 @@
2020
RSpec.configuration.render_views = false
2121
RSpec.configuration.render_views
2222

23-
RSpec.configuration.render_views?.should be_true
23+
RSpec.configuration.render_views?.should be_truthy
2424
end
2525
end
2626
end

spec/rspec/rails/mocks/mock_model_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
end
132132

133133
it "can be stubbed" do
134-
mock_model(MockableModel, :is_a? => true).is_a?(:Foo).should be_true
134+
mock_model(MockableModel, :is_a? => true).is_a?(:Foo).should be_truthy
135135
end
136136
end
137137

@@ -149,7 +149,7 @@
149149
end
150150

151151
it "can be stubbed" do
152-
mock_model(MockableModel, :kind_of? => true).kind_of?(:Foo).should be_true
152+
mock_model(MockableModel, :kind_of? => true).kind_of?(:Foo).should be_truthy
153153
end
154154
end
155155

@@ -167,7 +167,7 @@
167167
end
168168

169169
it "can be stubbed" do
170-
mock_model(MockableModel, :instance_of? => true).instance_of?(:Foo).should be_true
170+
mock_model(MockableModel, :instance_of? => true).instance_of?(:Foo).should be_truthy
171171
end
172172
end
173173

@@ -257,7 +257,7 @@
257257
end
258258

259259
it "can be stubbed" do
260-
mock_model(MockableModel, :respond_to? => true).respond_to?(:foo).should be_true
260+
mock_model(MockableModel, :respond_to? => true).respond_to?(:foo).should be_truthy
261261
end
262262
end
263263

spec/rspec/rails/mocks/stub_model_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,14 @@ def model_class
5858
context "default" do
5959
it "returns false" do
6060
model = stub_model(model_class)
61-
model.new_record?.should be_false
61+
model.new_record?.should be_falsey
6262
end
6363
end
6464

6565
context "with as_new_record" do
6666
it "returns true" do
6767
model = stub_model(model_class).as_new_record
68-
model.new_record?.should be_true
68+
model.new_record?.should be_truthy
6969
end
7070
end
7171
end

spec/rspec/rails/view_rendering_spec.rb

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ def controller
1414
context "default" do
1515
context "ActionController::Base" do
1616
it "does not render views" do
17-
group.new.render_views?.should be_false
17+
group.new.render_views?.should be_falsey
1818
end
1919

2020
it "does not render views in a nested group" do
21-
group.describe{}.new.render_views?.should be_false
21+
group.describe{}.new.render_views?.should be_falsey
2222
end
2323
end
2424

@@ -28,7 +28,7 @@ def controller
2828
def example.controller
2929
ActionController::Metal.new
3030
end
31-
example.render_views?.should be_true
31+
example.render_views?.should be_truthy
3232
end
3333
end
3434
end
@@ -38,27 +38,27 @@ def example.controller
3838
context "with no args" do
3939
it "tells examples to render views" do
4040
group.render_views
41-
group.new.render_views?.should be_true
41+
group.new.render_views?.should be_truthy
4242
end
4343
end
4444

4545
context "with true" do
4646
it "tells examples to render views" do
4747
group.render_views true
48-
group.new.render_views?.should be_true
48+
group.new.render_views?.should be_truthy
4949
end
5050
end
5151

5252
context "with false" do
5353
it "tells examples not to render views" do
5454
group.render_views false
55-
group.new.render_views?.should be_false
55+
group.new.render_views?.should be_falsey
5656
end
5757

5858
it "overrides the global config if render_views is enabled there" do
5959
RSpec.configuration.stub(:render_views?).and_return true
6060
group.render_views false
61-
group.new.render_views?.should be_false
61+
group.new.render_views?.should be_falsey
6262
end
6363
end
6464

@@ -70,40 +70,40 @@ def example.controller
7070
context "with no args" do
7171
it "tells examples to render views" do
7272
nested_group.render_views
73-
nested_group.new.render_views?.should be_true
73+
nested_group.new.render_views?.should be_truthy
7474
end
7575
end
7676

7777
context "with true" do
7878
it "tells examples to render views" do
7979
nested_group.render_views true
80-
nested_group.new.render_views?.should be_true
80+
nested_group.new.render_views?.should be_truthy
8181
end
8282
end
8383

8484
context "with false" do
8585
it "tells examples not to render views" do
8686
nested_group.render_views false
87-
nested_group.new.render_views?.should be_false
87+
nested_group.new.render_views?.should be_falsey
8888
end
8989
end
9090

9191
it "leaves the parent group as/is" do
9292
group.render_views
9393
nested_group.render_views false
94-
group.new.render_views?.should be_true
94+
group.new.render_views?.should be_truthy
9595
end
9696

9797
it "overrides the value inherited from the parent group" do
9898
group.render_views
9999
nested_group.render_views false
100-
nested_group.new.render_views?.should be_false
100+
nested_group.new.render_views?.should be_falsey
101101
end
102102

103103
it "passes override to children" do
104104
group.render_views
105105
nested_group.render_views false
106-
nested_group.describe{}.new.render_views?.should be_false
106+
nested_group.describe{}.new.render_views?.should be_falsey
107107
end
108108
end
109109
end

0 commit comments

Comments
 (0)