Extract method from scaffold request spec template to ScaffoldGenerator

Author: klyonrad

.rubocop.yml

@@ -104,6 +104,10 @@ Metrics/BlockLength:
 # Warns when the class is excessively long.
 Metrics/ClassLength:
   Max: 100
+  Exclude:
+    # Splitting the Generator classes would make matters more confusing
+    # than them being too big
+    - lib/generators/rspec/**/*
 
 Metrics/PerceivedComplexity:
   Enabled: false

lib/generators/rspec/scaffold/scaffold_generator.rb

@@ -112,6 +112,11 @@ def ns_suffix
         @ns_suffix ||= ns_parts[-1]
       end
 
+      def singular_url_helper(record_name)
+        # Similar to Rails::Generators::NamedBase.show_helper - but singular_route_name method is not available
+        "#{singular_table_name}_url(#{record_name})"
+      end
+
       def value_for(attribute)
         raw_value_for(attribute).inspect
       end

lib/generators/rspec/scaffold/templates/request_spec.rb

@@ -40,7 +40,7 @@
   describe "GET /show" do
     it "renders a successful response" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
-      get <%= "#{singular_table_name}_url(#{file_name})" %>
+      get <%= singular_url_helper(file_name) %>
       expect(response).to be_successful
     end
   end
@@ -55,7 +55,7 @@
   describe "GET /edit" do
     it "render a successful response" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
-      get <%= "edit_#{singular_table_name}_url(#{file_name})" %>
+      get <%= "edit_#{singular_url_helper(file_name)}" %>
       expect(response).to be_successful
     end
   end
@@ -70,7 +70,7 @@
 
       it "redirects to the created <%= ns_file_name %>" do
         post <%= "#{index_helper}_path" %>, params: { <%= ns_file_name %>: valid_attributes }
-        expect(response).to redirect_to(<%= singular_table_name %>_url(<%= class_name %>.last))
+        expect(response).to redirect_to(<%= singular_url_helper("#{class_name}.last") %>)
       end
     end
 
@@ -103,7 +103,7 @@
 
       it "redirects to the <%= ns_file_name %>" do
         <%= file_name %> = <%= class_name %>.create! valid_attributes
-        patch <%= "#{singular_table_name}_url(#{file_name})" %>, params: { <%= singular_table_name %>: new_attributes }
+        patch <%= singular_url_helper(file_name) %>, params: { <%= singular_table_name %>: new_attributes }
         <%= file_name %>.reload
         expect(response).to redirect_to(<%= singular_table_name %>_url(<%= file_name %>))
       end
@@ -112,7 +112,7 @@
     context "with invalid parameters" do
       it "renders a successful response (i.e. to display the 'edit' template)" do
         <%= file_name %> = <%= class_name %>.create! valid_attributes
-        patch <%= "#{singular_table_name}_url(#{file_name})" %>, params: { <%= singular_table_name %>: invalid_attributes }
+        patch <%= singular_url_helper(file_name) %>, params: { <%= singular_table_name %>: invalid_attributes }
         expect(response).to be_successful
       end
     end
@@ -122,13 +122,13 @@
     it "destroys the requested <%= ns_file_name %>" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
       expect {
-        delete <%= "#{singular_table_name}_url(#{file_name})" %>
+        delete <%= singular_url_helper(file_name) %>
       }.to change(<%= class_name %>, :count).by(-1)
     end
 
     it "redirects to the <%= table_name %> list" do
       <%= file_name %> = <%= class_name %>.create! valid_attributes
-      delete <%= "#{singular_table_name}_url(#{file_name})" %>
+      delete <%= singular_url_helper(file_name) %>
       expect(response).to redirect_to(<%= "#{index_helper}_url" %>)
     end
   end