Skip to content

Commit 2b8fffe

Browse files
committed
Turn pending test to a regular one for Rails 5.2
ActiveSupport::Cache::RedisCacheStore's usage of safe navigation was fixed in Rails 5.2.5: https://github.com/rails/rails/blob/v5.2.4.3/activesupport/lib/active_support/cache/redis_cache_store.rb#L323 https://github.com/rails/rails/blob/v5.2.5/activesupport/lib/active_support/cache/redis_cache_store.rb#L323 In ActionDispatch::Request::Session it was fixed, too: https://github.com/rails/rails/blob/v5.2.4.3/actionpack/lib/action_dispatch/request/session.rb#L96 https://github.com/rails/rails/blob/v5.2.5/actionpack/lib/action_dispatch/request/session.rb#L96 Our `pending` was actually failing (since the test was passing) for some while. :question: Do we need to keep the build for `5-2-stable`?
1 parent 969a5b2 commit 2b8fffe

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ jobs:
6868
env:
6969
RAILS_VERSION: '~> 5.2.0'
7070
- ruby: 2.2.10
71-
allow_failure: true
7271
env:
7372
RAILS_VERSION: '~> 5.2.0'
7473
- ruby: 2.2.10

spec/rspec/rails/example/view_example_group_spec.rb

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -239,19 +239,8 @@ def _view; end # Stub method
239239
expect(view_spec.view).to eq(view)
240240
end
241241

242-
if RUBY_VERSION <= "2.3.0" && ENV["RAILS_VERSION"] !~ /stable/ && ::Rails.version.to_f == 5.2
243-
pending_only_on_ruby_22_rails_52 = """
244-
Rails 5.2.4.2 has a syntax error in ActionDispatch::Request::Session.
245-
(A &. usage which does not work in 2.2.10)
246-
It has been fixed but not released, this spec will not pass until that
247-
has been released.
248-
"""
249-
else
250-
pending_only_on_ruby_22_rails_52 = false
251-
end
252-
253242
# Regression test from rspec/rspec-rails#833
254-
it 'is accessible to configuration-level hooks', pending: pending_only_on_ruby_22_rails_52 do
243+
it 'is accessible to configuration-level hooks' do
255244
run_count = 0
256245
RSpec.configuration.before(:each, type: :view) do
257246
# `view` is provided from the view example type, and serves to

0 commit comments

Comments
 (0)