Skip to content

Commit 2bf4a6f

Browse files
committed
Apply second round of fixes per @JonRowe's review
1 parent 0449b2f commit 2bf4a6f

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,8 +271,8 @@ RSpec.describe User, type: :model do
271271

272272
### System specs, feature specs, request specs–what’s the difference?
273273

274-
RSpec Rails provides three types of specs
275-
that do not directly correspond to any Rails application component.
274+
RSpec Rails provides some end-to-end (entire application) testing capability
275+
to specify the interaction with the client.
276276

277277
#### System specs
278278

features/matchers/have_http_status_matcher.feature

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ Feature: `have_http_status` matcher
33
The `have_http_status` matcher is used to specify that a response returns a
44
desired status code. It accepts one argument in any of the following formats:
55

6-
* numeric
7-
* name (defined in `Rack::Utils::SYMBOL_TO_STATUS_CODE`)
8-
* `ActionDispatch::TestResponse` alias (`:success`, `:missing`, `:redirect`, or `:error`)
6+
* numeric code
7+
* status name as defined in `Rack::Utils::SYMBOL_TO_STATUS_CODE`
8+
* generic status type (`:success`, `:missing`, `:redirect`, or `:error`)
99

1010
The matcher works on any `response` object. It is available for use in
1111
[controller specs](../controller-specs), [request specs](../request-specs), and [feature specs](../feature-specs).
1212

13-
Scenario: Checking a numeric response code
13+
Scenario: Checking a numeric status code
1414
Given a file named "spec/controllers/application_controller_spec.rb" with:
1515
"""ruby
1616
require "rails_helper"
@@ -35,7 +35,7 @@ Feature: `have_http_status` matcher
3535
When I run `rspec spec`
3636
Then the examples should all pass
3737

38-
Scenario: Checking a symbolic response code (by name)
38+
Scenario: Checking a symbolic status name
3939
Given a file named "spec/controllers/application_controller_spec.rb" with:
4040
"""ruby
4141
require "rails_helper"
@@ -60,7 +60,7 @@ Feature: `have_http_status` matcher
6060
When I run `rspec spec`
6161
Then the examples should all pass
6262

63-
Scenario: Checking a symbolic response code (by `ActionDispatch::TestRespose` alias)
63+
Scenario: Checking a symbolic generic status type
6464
Given a file named "spec/controllers/application_controller_spec.rb" with:
6565
"""ruby
6666
require "rails_helper"

features/view_specs/view_spec.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ Feature: view spec
44
or if you have set `config.infer_spec_type_from_file_location!`
55
by placing them in `spec/views`.
66

7-
Use them to test the content of view templates in isolation
8-
(that is, without invoking a controller).
7+
Use them to test the content of view templates
8+
without invoking a specific controller.
99
They generally follow three steps:
1010

1111
```ruby

0 commit comments

Comments
 (0)