Get cukes passing on 5.1

Author: Sam Phippen

Rakefile

@@ -29,11 +29,21 @@ end
 Cucumber::Rake::Task.new(:cucumber) do |t|
   version = ENV.fetch("RAILS_VERSION", "~> 4.2.0")
   cucumber_flag = "--tags ~@rails_post_5"
-  p version
-  if /(^| )5(\.|-)0/ === version || version == "master"
-    cucumber_flag = "--tags ~@rails_pre_5"
+  tags = []
+  if version.to_f >= 5.1
+    tags << "~@rails_pre_5.1"
   end
 
+  if version.to_f >= 5.0
+    tags << "~@rails_pre_5"
+  end
+
+  if tags.empty?
+    tags << "~@rails_post_5"
+  end
+
+  cucumber_flag = tags.map { |tag| "--tag #{tag}" }
+
   t.cucumber_opts = cucumber_flag
 end
 

features/controller_specs/anonymous_controller.feature

@@ -293,6 +293,7 @@ Feature: anonymous controller
     When I run `rspec spec`
     Then the examples should all pass
 
+  @rails_pre_5
   Scenario: Invoke `around_filter` and `around_action` in base class
     Given a file named "spec/controllers/application_controller_around_filter_spec.rb" with:
       """ruby
@@ -324,6 +325,38 @@ Feature: anonymous controller
     When I run `rspec spec`
     Then the examples should all pass
 
+  @rails_post_5
+  Scenario: Invoke `around_filter` and `around_action` in base class
+    Given a file named "spec/controllers/application_controller_around_filter_spec.rb" with:
+      """ruby
+      require "rails_helper"
+
+      class ApplicationController < ActionController::Base
+        around_action :an_around_filter
+
+        def an_around_filter
+          @callback_invoked = true
+          yield
+        end
+      end
+
+      RSpec.describe ApplicationController, :type => :controller do
+        controller do
+          def index
+            render :plain => ""
+          end
+        end
+
+        it "invokes the callback" do
+          get :index
+
+          expect(assigns[:callback_invoked]).to be_truthy
+        end
+      end
+      """
+    When I run `rspec spec`
+    Then the examples should all pass
+
   @rails_pre_5
   Scenario: Anonymous controllers only create resource routes
     Given a file named "spec/controllers/application_controller_spec.rb" with:
@@ -610,7 +643,7 @@ Feature: anonymous controller
 
         describe "#edit" do
           it "responds to GET" do
-            get :edit, :id => "anyid"
+            get :edit, :params => { :id => "anyid" }
             expect(response.body).to eq "edit called"
           end
 
@@ -621,15 +654,15 @@ Feature: anonymous controller
           # And the rest...
           %w{get post put delete}.each do |calltype|
             it "responds to #{calltype}" do
-              send(calltype, :edit, {:id => "anyid"})
+              send(calltype, :edit, :params => {:id => "anyid"})
               expect(response.body).to eq "edit called"
             end
           end
         end
 
         describe "#show" do
           it "responds to GET" do
-            get :show, :id => "anyid"
+            get :show, :params => { :id => "anyid" }
             expect(response.body).to eq "show called"
           end
 
@@ -640,15 +673,15 @@ Feature: anonymous controller
           # And the rest...
           %w{get post put delete}.each do |calltype|
             it "responds to #{calltype}" do
-              send(calltype, :show, {:id => "anyid"})
+              send(calltype, :show, :params => {:id => "anyid"})
               expect(response.body).to eq "show called"
             end
           end
         end
 
         describe "#update" do
           it "responds to PUT" do
-            put :update, :id => "anyid"
+            put :update, :params => { :id => "anyid" }
             expect(response.body).to eq "update called"
           end
 
@@ -659,15 +692,15 @@ Feature: anonymous controller
           # And the rest...
           %w{get post put delete}.each do |calltype|
             it "responds to #{calltype}" do
-              send(calltype, :update, {:id => "anyid"})
+              send(calltype, :update, :params =>  {:id => "anyid"})
               expect(response.body).to eq "update called"
             end
           end
         end
 
         describe "#destroy" do
           it "responds to DELETE" do
-            delete :destroy, :id => "anyid"
+            delete :destroy, :params => { :id => "anyid" }
             expect(response.body).to eq "destroy called"
           end
 
@@ -678,7 +711,7 @@ Feature: anonymous controller
           # And the rest...
           %w{get post put delete}.each do |calltype|
             it "responds to #{calltype}" do
-              send(calltype, :destroy, {:id => "anyid"})
+              send(calltype, :destroy, :params => {:id => "anyid"})
               expect(response.body).to eq "destroy called"
             end
           end

features/controller_specs/controller_spec.feature

@@ -34,6 +34,7 @@ Feature: controller spec
     When I run `rspec spec`
     Then the example should pass
 
+  @rails_pre_5
   Scenario: setting a different content type for example json (request type)
     Given a file named "spec/controllers/widgets_controller_spec.rb" with:
       """ruby
@@ -55,3 +56,26 @@ Feature: controller spec
       """
     When I run `rspec spec`
     Then the example should pass
+
+  @rails_post_5
+  Scenario: setting a different content type for example json (request type)
+    Given a file named "spec/controllers/widgets_controller_spec.rb" with:
+      """ruby
+      require "rails_helper"
+
+      RSpec.describe WidgetsController, :type => :controller do
+        describe "responds to" do
+          it "responds to html by default" do
+            post :create, :params => { :widget => { :name => "Any Name" } }
+            expect(response.content_type).to eq "text/html"
+          end
+
+          it "responds to custom formats when provided in the params" do
+            post :create, :params => { :widget => { :name => "Any Name" }, :format => :json }
+            expect(response.content_type).to eq "application/json"
+          end
+        end
+      end
+      """
+    When I run `rspec spec`
+    Then the example should pass

features/feature_specs/feature_spec.feature

@@ -20,6 +20,7 @@ Feature: Feature spec
   [customer](http://c2.com/cgi/wiki?CustomerTest) and [acceptance](http://c2.com/cgi/wiki?AcceptanceTest) tests. When capybara is required it sets
   `:type => :feature` automatically for you.
 
+  @rails_pre_5.1
   Scenario: Feature specs are skipped without Capybara
     Given a file named "spec/features/widget_management_spec.rb" with:
       """ruby
@@ -58,7 +59,6 @@ Feature: Feature spec
         scenario "User creates a new widget" do
           visit "/widgets/new"
 
-          fill_in "Name", :with => "My Widget"
           click_button "Create Widget"
 
           expect(page).to have_text("Widget was successfully created.")

features/matchers/have_http_status_matcher.feature

@@ -100,6 +100,7 @@ Feature: `have_http_status` matcher
     When I run `rspec spec/controllers/gadgets_spec.rb`
     Then the examples should all pass
 
+  @rails_pre_5
   Scenario: Using in a request spec
     Given a file named "spec/requests/gadgets/widget_management_spec.rb" with:
       """ruby
@@ -124,6 +125,31 @@ Feature: `have_http_status` matcher
     When I run `rspec spec/requests`
     Then the examples should all pass
 
+  @rails_post_5
+  Scenario: Using in a request spec
+    Given a file named "spec/requests/gadgets/widget_management_spec.rb" with:
+      """ruby
+      require "rails_helper"
+
+      RSpec.describe "Widget management", :type => :request do
+
+        it "creates a Widget and redirects to the Widget's page" do
+          get "/widgets/new"
+          expect(response).to have_http_status(:ok)
+
+          post "/widgets", :params => { :widget => {:name => "My Widget"} }
+          expect(response).to have_http_status(302)
+
+          follow_redirect!
+
+          expect(response).to have_http_status(:success)
+        end
+
+      end
+      """
+    When I run `rspec spec/requests`
+    Then the examples should all pass
+
   @capybara
   Scenario: Using in a feature spec
     Given a file named "spec/features/widget_management_spec.rb" with:
@@ -136,7 +162,6 @@ Feature: `have_http_status` matcher
           visit "/widgets/new"
           expect(page).to have_http_status(200)
 
-          fill_in "Name", :with => "My Widget"
           click_button "Create Widget"
 
           expect(page).to have_http_status(:success)

features/matchers/redirect_to_matcher.feature

@@ -7,6 +7,7 @@ Feature: redirect_to matcher
   It is available in controller specs (spec/controllers) and request
   specs (spec/requests).
 
+  @rails_pre_5
   Scenario: redirect_to with four possible options
     Given a file named "spec/controllers/widgets_controller_spec.rb" with:
       """ruby
@@ -38,3 +39,36 @@ Feature: redirect_to matcher
       """
     When I run `rspec spec/controllers/widgets_controller_spec.rb`
     Then the examples should all pass
+
+  @rails_post_5
+  Scenario: redirect_to with four possible options
+    Given a file named "spec/controllers/widgets_controller_spec.rb" with:
+      """ruby
+      require "rails_helper"
+
+      RSpec.describe WidgetsController do
+
+        describe "#create" do
+          subject { post :create, :params => { :widget => { :name => "Foo" } } }
+
+          it "redirects to widget_url(@widget)" do
+            expect(subject).to redirect_to(widget_url(assigns(:widget)))
+          end
+
+          it "redirects_to :action => :show" do
+            expect(subject).to redirect_to :action => :show,
+                                           :id => assigns(:widget).id
+          end
+
+          it "redirects_to(@widget)" do
+            expect(subject).to redirect_to(assigns(:widget))
+          end
+
+          it "redirects_to /widgets/:id" do
+            expect(subject).to redirect_to("/widgets/#{assigns(:widget).id}")
+          end
+        end
+      end
+      """
+    When I run `rspec spec/controllers/widgets_controller_spec.rb`
+    Then the examples should all pass

features/request_specs/request_spec.feature

@@ -26,6 +26,7 @@ Feature: request spec
   request specs as of Capybara 2.0.0. The recommended way to use Capybara is
   with [feature specs](../feature-specs/feature-spec).
 
+  @rails_pre_5
   Scenario: specify managing a Widget with Rails integration methods
     Given a file named "spec/requests/widget_management_spec.rb" with:
       """ruby
@@ -55,7 +56,38 @@ Feature: request spec
     When I run `rspec spec/requests/widget_management_spec.rb`
     Then the example should pass
 
-  @unsupported-on-rails-3-0
+  @rails_post_5
+  Scenario: specify managing a Widget with Rails integration methods
+    Given a file named "spec/requests/widget_management_spec.rb" with:
+      """ruby
+      require "rails_helper"
+
+      RSpec.describe "Widget management", :type => :request do
+
+        it "creates a Widget and redirects to the Widget's page" do
+          get "/widgets/new"
+          expect(response).to render_template(:new)
+
+          post "/widgets", :params => { :widget => {:name => "My Widget"} }
+
+          expect(response).to redirect_to(assigns(:widget))
+          follow_redirect!
+
+          expect(response).to render_template(:show)
+          expect(response.body).to include("Widget was successfully created.")
+        end
+
+        it "does not render a different template" do
+          get "/widgets/new"
+          expect(response).to_not render_template(:show)
+        end
+      end
+      """
+    When I run `rspec spec/requests/widget_management_spec.rb`
+    Then the example should pass
+
+
+  @unsupported-on-rails-3-0 @rails_pre_5
   Scenario: requesting a JSON response
     Given a file named "spec/requests/widget_management_spec.rb" with:
       """ruby
@@ -79,6 +111,31 @@ Feature: request spec
     When I run `rspec spec/requests/widget_management_spec.rb`
     Then the example should pass
 
+  @rails_post_5
+  Scenario: requesting a JSON response
+    Given a file named "spec/requests/widget_management_spec.rb" with:
+      """ruby
+      require "rails_helper"
+
+      RSpec.describe "Widget management", :type => :request do
+
+        it "creates a Widget" do
+          headers = {
+            "ACCEPT" => "application/json",     # This is what Rails 4 accepts
+            "HTTP_ACCEPT" => "application/json" # This is what Rails 3 accepts
+          }
+          post "/widgets", :params => { :widget => {:name => "My Widget"} }, :headers => headers
+
+          expect(response.content_type).to eq("application/json")
+          expect(response).to have_http_status(:created)
+        end
+
+      end
+      """
+    When I run `rspec spec/requests/widget_management_spec.rb`
+    Then the example should pass
+
+  @rails_pre_5
   Scenario: providing JSON data
     Given a file named "spec/requests/widget_management_spec.rb" with:
     """ruby
@@ -96,3 +153,22 @@ Feature: request spec
     """
     When I run `rspec spec/requests/widget_management_spec.rb`
     Then the example should pass
+
+  @rails_post_5
+  Scenario: providing JSON data
+    Given a file named "spec/requests/widget_management_spec.rb" with:
+    """ruby
+    require "rails_helper"
+
+    RSpec.describe "Widget management", :type => :request do
+
+      it "creates a Widget and redirects to the Widget's page" do
+      headers = { "CONTENT_TYPE" => "application/json" }
+      post "/widgets", :params => '{ "widget": { "name":"My Widget" } }', :headers => headers
+        expect(response).to redirect_to(assigns(:widget))
+      end
+
+    end
+    """
+    When I run `rspec spec/requests/widget_management_spec.rb`
+    Then the example should pass