Rely on ::Rails::VERSION::STRING instead of an overly complex module

* I did not know about ::Rails::VERSION::STRING until recently. It seems
  to be defined all the way back to 3.0.0, which is all we need.

Author: alindeman

features/model_specs/errors_on.feature

@@ -10,7 +10,7 @@ Feature: errors_on
         validates_presence_of :name
 
         # In Rails 4, mass assignment protection is implemented on controllers
-        attr_accessible :name if RSpec::Rails.rails_version_satisfied_by?('< 4.0.0.beta1')
+        attr_accessible :name if ::Rails::VERSION::STRING < '4'
 
         validates_length_of :name, :minimum => 10, :on => :publication
       end

lib/generators/rspec.rb

@@ -1,5 +1,4 @@
 require 'rails/generators/named_base'
-require 'rspec/rails/rails_version'
 
 module Rspec
   module Generators
@@ -8,7 +7,7 @@ def self.source_root
         @_rspec_source_root ||= File.expand_path(File.join(File.dirname(__FILE__), 'rspec', generator_name, 'templates'))
       end
 
-      if RSpec::Rails.rails_version_satisfied_by?('< 3.1')
+      if ::Rails::VERSION::STRING < '3.1'
         def module_namespacing
           yield if block_given?
         end

lib/generators/rspec/install/install_generator.rb

@@ -1,5 +1,3 @@
-require 'rspec/rails/rails_version'
-
 module Rspec
   module Generators
     class InstallGenerator < ::Rails::Generators::Base

lib/generators/rspec/install/templates/spec/spec_helper.rb.tt

@@ -8,7 +8,7 @@ require 'rspec/autorun'
 # in spec/support/ and its subdirectories.
 Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f }
 
-<% if RSpec::Rails.rails_version_satisfied_by?('>= 4.0.0.beta1') -%>
+<% if ::Rails::VERSION::STRING >= '4' -%>
 # Checks for pending migrations before tests are run.
 # If you are not using ActiveRecord, you can remove this line.
 ActiveRecord::Migration.check_pending! if defined?(ActiveRecord::Migration)

lib/generators/rspec/scaffold/templates/controller_spec.rb

@@ -109,7 +109,7 @@
         # specifies that the <%= class_name %> created on the previous line
         # receives the :update_attributes message with whatever params are
         # submitted in the request.
-        <%- if RSpec::Rails.rails_version_satisfied_by?('>= 4.0.0.beta1') -%>
+        <%- if ::Rails::VERSION::STRING >= '4' -%>
         <%= class_name %>.any_instance.should_receive(:update).with(<%= formatted_hash(example_params_for_update) %>)
         <%- else -%>
         <%= class_name %>.any_instance.should_receive(:update_attributes).with(<%= formatted_hash(example_params_for_update) %>)

lib/rspec/rails.rb

@@ -5,7 +5,7 @@
   c.backtrace_exclusion_patterns << /lib\/rspec\/rails/
 end
 
-require 'rspec/rails/rails_version'
+require 'rails/version'
 require 'rspec/rails/extensions'
 require 'rspec/rails/view_rendering'
 require 'rspec/rails/adapters'

lib/rspec/rails/example/rails_example_group.rb

@@ -1,14 +1,13 @@
 # Temporary workaround to resolve circular dependency between rspec-rails' spec
 # suite and ammeter.
 require 'rspec/rails/matchers'
-require 'rspec/rails/rails_version'
 
 module RSpec
   module Rails
     module RailsExampleGroup
       extend ActiveSupport::Concern
       include RSpec::Rails::SetupAndTeardownAdapter
-      include RSpec::Rails::MiniTestLifecycleAdapter if RSpec::Rails.rails_version_satisfied_by?('>= 4.0.0.beta1')
+      include RSpec::Rails::MiniTestLifecycleAdapter if ::Rails::VERSION::STRING >= '4'
       include RSpec::Rails::TestUnitAssertionAdapter
       include RSpec::Rails::Matchers
     end

lib/rspec/rails/example/view_example_group.rb

@@ -107,7 +107,7 @@ def _default_file_to_render
       end
 
       def _default_render_options
-        if RSpec::Rails.rails_version_satisfied_by?('>= 3.2')
+        if ::Rails::VERSION::STRING >= '3.2'
           # pluck the handler, format, and locale out of, eg, posts/index.de.html.haml
           template, *components   = _default_file_to_render.split('.')
           handler, format, locale = *components.reverse

lib/rspec/rails/fixture_support.rb

@@ -4,7 +4,7 @@ module Rails
       module FixtureSupport
         extend ActiveSupport::Concern
         include RSpec::Rails::SetupAndTeardownAdapter
-        include RSpec::Rails::MiniTestLifecycleAdapter if RSpec::Rails.rails_version_satisfied_by?('>= 4.0.0.beta1')
+        include RSpec::Rails::MiniTestLifecycleAdapter if ::Rails::VERSION::STRING > '4'
         include RSpec::Rails::TestUnitAssertionAdapter
         include ActiveRecord::TestFixtures
 

lib/rspec/rails/rails_version.rb

@@ -16,7 +16,7 @@
     File.read( file('spec/spec_helper.rb') ).should =~ /^require 'rspec\/autorun'$/m
   end
 
-  if RSpec::Rails.rails_version_satisfied_by?('>= 4.0.0.beta1')
+  if ::Rails::VERSION::STRING >= '4'
     it "generates spec/spec_helper.rb with a check for pending migrations" do
       run_generator
       File.read( file('spec/spec_helper.rb') ).should =~ /ActiveRecord::Migration\.check_pending!/m

spec/generators/rspec/install/install_generator_spec.rb

@@ -118,7 +118,7 @@ def _assigns
           view_spec.stub(:_default_file_to_render) { "widgets/new.en.html.erb" }
           view_spec.render
 
-          if RSpec::Rails.rails_version_satisfied_by?('>= 3.2')
+          if ::Rails::VERSION::STRING >= '3.2'
             view_spec.received.first.should == [{:template => "widgets/new", :locales=>['en'], :formats=>['html'], :handlers=>['erb']}, {}, nil]
           else
             view_spec.received.first.should == [{:template => "widgets/new.en.html.erb"}, {}, nil]

spec/rspec/rails/example/view_example_group_spec.rb

@@ -5,7 +5,7 @@
 
   let!(:models) { Array.new(3) { MockableModel.create } }
 
-  if RSpec::Rails.rails_version_satisfied_by?('>= 4.0.0.beta1')
+  if ::Rails::VERSION::STRING >= '4'
     it "verifies that the scope returns the records on the right hand side, regardless of order" do
       MockableModel.all.should =~ models.reverse
     end