Avoid deprecated TestResponse#success? method

Closes #2009

TestResponse#success? was deprecated with [this
commit](rails/rails@af3500b).
Instead, we can use #successful? from Rack::Response::Helpers. This
method has been available for a long time. I tried this change with
Rails 3.2, 4.2, and 5.2 and everything seemed to work fine.

Author: composerinteralia

lib/generators/rspec/scaffold/templates/api_controller_spec.rb

@@ -51,7 +51,7 @@
 <% else -%>
       get :index, params: {}, session: valid_session
 <% end -%>
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 
@@ -64,7 +64,7 @@
 <% else -%>
       get :show, params: {id: <%= file_name %>.to_param}, session: valid_session
 <% end -%>
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 

lib/generators/rspec/scaffold/templates/controller_spec.rb

@@ -51,7 +51,7 @@
 <% else -%>
       get :index, params: {}, session: valid_session
 <% end -%>
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 
@@ -64,7 +64,7 @@
 <% else -%>
       get :show, params: {id: <%= file_name %>.to_param}, session: valid_session
 <% end -%>
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 
@@ -75,7 +75,7 @@
 <% else -%>
       get :new, params: {}, session: valid_session
 <% end -%>
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 
@@ -87,7 +87,7 @@
 <% else -%>
       get :edit, params: {id: <%= file_name %>.to_param}, session: valid_session
 <% end -%>
-      expect(response).to be_success
+      expect(response).to be_successful
     end
   end
 
@@ -120,7 +120,7 @@
 <% else -%>
         post :create, params: {<%= ns_file_name %>: invalid_attributes}, session: valid_session
 <% end -%>
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
   end
@@ -161,7 +161,7 @@
 <% else -%>
         put :update, params: {id: <%= file_name %>.to_param, <%= ns_file_name %>: invalid_attributes}, session: valid_session
 <% end -%>
-        expect(response).to be_success
+        expect(response).to be_successful
       end
     end
   end