Skip to content

Commit 4a933fd

Browse files
authored
Merge pull request #2174 from rspec/fix-build-4-0-dev
Pin minitest on older Rubies
2 parents c11a1b6 + 92f5ef5 commit 4a933fd

File tree

4 files changed

+45
-11
lines changed

4 files changed

+45
-11
lines changed

ISSUE_TEMPLATE.md renamed to .github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
1-
<!--
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: ''
6+
assignees: ''
27

3-
Hi there! Here's a few pointers to help us help you with your issue as quickly
4-
as possible.
8+
---
59

6-
We prefer that the RSpec Rails issue tracker be mainly used for bug reports.
7-
Feature requests or general requests for help should go to our google group:
8-
[email protected]. We use that as our primary location for higher level
9-
RSpec discussions.
10+
<!--
1011
11-
If you are filing a bug report, there's a few steps it'd be super if you could
12-
follow. If you can't do all of these, don't worry, but if you can it'll help us
12+
Below are a few steps it'd be super if you could follow.
13+
If you can't do all of these, don't worry, but if you can it'll help us
1314
resolve your bug faster!
1415
1516
-->
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: ''
6+
assignees: ''
7+
8+
---
9+
10+
<!--
11+
12+
Feature requests or general requests for help should first go to our google group:
13+
[email protected]. We use that as our primary location for higher level
14+
RSpec discussions.
15+
16+
-->
17+
18+
**Is your feature request related to a problem? Please describe.**
19+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
20+
21+
**Describe the solution you'd like**
22+
A clear and concise description of what you want to happen.
23+
24+
**Describe alternatives you've considered**
25+
A clear and concise description of any alternative solutions or features you've considered.
26+
27+
**Additional context**
28+
Add any other context or screenshots about the feature request here.

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ We welcome contributions from *everyone*. While contributing, please follow the
1111
If you'd like to help make RSpec better, here are some ways you can contribute:
1212

1313
- by running RSpec HEAD to help us catch bugs before new releases
14-
- by [reporting bugs you encounter](https://github.com/rspec/rspec-rails/issues/new)
15-
- by [suggesting new features](https://github.com/rspec/rspec-rails/issues/new)
14+
- by [reporting bugs you encounter](https://github.com/rspec/rspec-rails/issues/new?template=bug_report.md)
15+
- by [suggesting new features](https://github.com/rspec/rspec-rails/issues/new?template=feature_request.md)
1616
- by improving RSpec's [Relish](https://relishapp.com/rspec) or [API](http://rspec.info/documentation/) documentation
1717
- by improving [RSpec's website](http://rspec.info/) ([source](https://github.com/rspec/rspec.github.io))
1818
- by taking part in [feature and issue discussions](https://github.com/rspec/rspec-rails/issues)

Gemfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@ gem 'rake', '~> 12'
4747

4848
gem 'mime-types', "~> 3"
4949

50+
# Version 5.12 of minitest requires Ruby 2.4
51+
if RUBY_VERSION < '2.4.0'
52+
gem 'minitest', '< 5.12.0'
53+
end
54+
5055
gem 'capybara', '~> 2.13', :require => false
5156

5257
if MAJOR == 6

0 commit comments

Comments
 (0)