Adjust SpaceInsideBlockBraces to give some space

Author: pirj

.rubocop.yml

@@ -72,6 +72,9 @@ Layout/SpaceInsidePercentLiteralDelimiters:
 Layout/SpaceAroundEqualsInParameterDefault:
   EnforcedStyle: space
 
+Layout/SpaceInsideBlockBraces:
+  EnforcedStyleForEmptyBraces: space
+
 Layout/SpaceAroundBlockParameters:
   Enabled: false
 

benchmarks/before_block_capture_block_vs_yield.rb

@@ -21,15 +21,15 @@ def capture_block_and_call_n_times(n, &block)
 
   Benchmark.ips do |x|
     x.report("Yield #{count} times                  ") do
-      yield_n_times(count) {}
+      yield_n_times(count) { }
     end
 
     x.report("Capture block and yield #{count} times") do
-      capture_block_and_yield_n_times(count) {}
+      capture_block_and_yield_n_times(count) { }
     end
 
     x.report("Capture block and call #{count} times ") do
-      capture_block_and_call_n_times(count) {}
+      capture_block_and_call_n_times(count) { }
     end
   end
 end

lib/rspec/rails/matchers/action_cable/have_broadcasted_to.rb

@@ -8,7 +8,7 @@ class HaveBroadcastedTo < RSpec::Matchers::BuiltIn::BaseMatcher
           def initialize(target, channel:)
             @target = target
             @channel = channel
-            @block = proc {}
+            @block = proc { }
             @data = nil
             set_expected_number(:exactly, 1)
           end

lib/rspec/rails/matchers/active_job.rb

@@ -15,7 +15,7 @@ def initialize
             @args = []
             @queue = nil
             @at = nil
-            @block = proc {}
+            @block = proc { }
             set_expected_number(:exactly, 1)
           end
 

spec/rspec/rails/example/controller_example_group_spec.rb

@@ -69,7 +69,7 @@ def my_helper
 
       before do
         group.class_exec do
-          controller(Class.new) {}
+          controller(Class.new) { }
         end
 
         allow(controller).to receive(:foos_url).and_return('http://test.host/foos')
@@ -116,13 +116,13 @@ def my_helper
         end
 
         it "infers the anonymous controller class" do
-          group.controller {}
+          group.controller { }
           expect(group.controller_class.superclass).to eq(anonymous_klass)
         end
 
         it "infers the anonymous controller class when no ApplicationController is present" do
           hide_const '::ApplicationController'
-          group.controller {}
+          group.controller { }
           expect(group.controller_class.superclass).to eq(anonymous_klass)
         end
       end
@@ -136,13 +136,13 @@ def my_helper
         end
 
         it "sets the anonymous controller class to ApplicationController" do
-          group.controller {}
+          group.controller { }
           expect(group.controller_class.superclass).to eq(ApplicationController)
         end
 
         it "sets the anonymous controller class to ActiveController::Base when no ApplicationController is present" do
           hide_const '::ApplicationController'
-          group.controller {}
+          group.controller { }
           expect(group.controller_class.superclass).to eq(ActionController::Base)
         end
       end
@@ -152,35 +152,35 @@ def my_helper
       let(:controller_class) { group.controller_class }
 
       it "sets the name as AnonymousController if it's anonymous" do
-        group.controller {}
+        group.controller { }
         expect(controller_class.name).to eq "AnonymousController"
       end
 
       it "sets the name according to defined controller if it is not anonymous" do
         stub_const "FoosController", Class.new(::ApplicationController)
-        group.controller(FoosController) {}
+        group.controller(FoosController) { }
         expect(controller_class.name).to eq "FoosController"
       end
 
       it "sets name as AnonymousController if defined as ApplicationController" do
-        group.controller(ApplicationController) {}
+        group.controller(ApplicationController) { }
         expect(controller_class.name).to eq "AnonymousController"
       end
 
       it "sets name as AnonymousController if the controller is abstract" do
         abstract_controller = Class.new(::ApplicationController)
         def abstract_controller.abstract?; true; end
 
-        group.controller(abstract_controller) {}
+        group.controller(abstract_controller) { }
         expect(controller_class.name).to eq "AnonymousController"
       end
 
       it "sets name as AnonymousController if it inherits outer group's anonymous controller" do
         outer_group = group_for ApplicationController
-        outer_group.controller {}
+        outer_group.controller { }
 
-        inner_group = group.describe {}
-        inner_group.controller(outer_group.controller_class) {}
+        inner_group = group.describe { }
+        inner_group.controller(outer_group.controller_class) { }
 
         expect(inner_group.controller_class.name).to eq "AnonymousController"
       end
@@ -192,7 +192,7 @@ def abstract_controller.abstract?; true; end
 
         it "sets the name according to the defined controller namespace if it is not anonymous" do
           stub_const "A::B::FoosController", Class.new(::ApplicationController)
-          group.controller(A::B::FoosController) {}
+          group.controller(A::B::FoosController) { }
           expect(controller_class.name).to eq "A::B::FoosController"
         end
 
@@ -201,7 +201,7 @@ def abstract_controller.abstract?; true; end
           def abstract_controller.abstract?; true; end
           stub_const "A::B::FoosController", abstract_controller
 
-          group.controller(A::B::FoosController) {}
+          group.controller(A::B::FoosController) { }
           expect(controller_class.name).to eq "AnonymousController"
         end
       end

spec/rspec/rails/matchers/action_cable/have_broadcasted_to_spec.rb

@@ -64,12 +64,12 @@ def broadcast(stream, msg)
     end
 
     it "passes when negated" do
-      expect {}.not_to have_broadcasted_to('stream')
+      expect { }.not_to have_broadcasted_to('stream')
     end
 
     it "fails when message is not sent" do
       expect {
-        expect {}.to have_broadcasted_to('stream')
+        expect { }.to have_broadcasted_to('stream')
       }.to raise_error(/expected to broadcast exactly 1 messages to stream, but broadcast 0/)
     end
 
@@ -85,7 +85,7 @@ def broadcast(stream, msg)
     it "reports correct number in fail error message" do
       broadcast('stream', 'one')
       expect {
-        expect {}.to have_broadcasted_to('stream').exactly(1)
+        expect { }.to have_broadcasted_to('stream').exactly(1)
       }.to raise_error(/expected to broadcast exactly 1 messages to stream, but broadcast 0/)
     end
 
@@ -139,7 +139,7 @@ def broadcast(stream, msg)
 
     it "generates failure message with at least hint" do
       expect {
-        expect {}.to have_broadcasted_to('stream').at_least(:once)
+        expect { }.to have_broadcasted_to('stream').at_least(:once)
       }.to raise_error(/expected to broadcast at least 1 messages to stream, but broadcast 0/)
     end
 

spec/rspec/rails/matchers/active_job_spec.rb

@@ -93,12 +93,12 @@ def self.name; "LoggingJob"; end
     end
 
     it "passes when negated" do
-      expect {}.not_to have_enqueued_job
+      expect { }.not_to have_enqueued_job
     end
 
     it "fails when job is not enqueued" do
       expect {
-        expect {}.to have_enqueued_job
+        expect { }.to have_enqueued_job
       }.to raise_error(/expected to enqueue exactly 1 jobs, but enqueued 0/)
     end
 
@@ -114,7 +114,7 @@ def self.name; "LoggingJob"; end
     it "reports correct number in fail error message" do
       heavy_lifting_job.perform_later
       expect {
-        expect {}.to have_enqueued_job.exactly(1)
+        expect { }.to have_enqueued_job.exactly(1)
       }.to raise_error(/expected to enqueue exactly 1 jobs, but enqueued 0/)
     end
 
@@ -184,7 +184,7 @@ def self.name; "LoggingJob"; end
 
     it "generates failure message with at least hint" do
       expect {
-        expect {}.to have_enqueued_job.at_least(:once)
+        expect { }.to have_enqueued_job.at_least(:once)
       }.to raise_error(/expected to enqueue at least 1 jobs, but enqueued 0/)
     end
 
@@ -442,12 +442,12 @@ def self.name; "LoggingJob"; end
     end
 
     it "passes when negated" do
-      expect {}.not_to have_performed_job
+      expect { }.not_to have_performed_job
     end
 
     it "fails when job is not performed" do
       expect {
-        expect {}.to have_performed_job
+        expect { }.to have_performed_job
       }.to raise_error(/expected to perform exactly 1 jobs, but performed 0/)
     end
 
@@ -463,7 +463,7 @@ def self.name; "LoggingJob"; end
     it "reports correct number in fail error message" do
       heavy_lifting_job.perform_later
       expect {
-        expect {}.to have_performed_job.exactly(1)
+        expect { }.to have_performed_job.exactly(1)
       }.to raise_error(/expected to perform exactly 1 jobs, but performed 0/)
     end
 
@@ -524,7 +524,7 @@ def self.name; "LoggingJob"; end
 
     it "generates failure message with at least hint" do
       expect {
-        expect {}.to have_performed_job.at_least(:once)
+        expect { }.to have_performed_job.at_least(:once)
       }.to raise_error(/expected to perform at least 1 jobs, but performed 0/)
     end
 

spec/rspec/rails/matchers/have_enqueued_mail_spec.rb

@@ -62,7 +62,7 @@ def email_with_args(arg1, arg2); end
     end
 
     it "passes when negated" do
-      expect {}.not_to have_enqueued_mail(TestMailer, :test_email)
+      expect { }.not_to have_enqueued_mail(TestMailer, :test_email)
     end
 
     it "passes when given 0 arguments" do
@@ -72,7 +72,7 @@ def email_with_args(arg1, arg2); end
     end
 
     it "passes when negated with 0 arguments" do
-      expect {}.not_to have_enqueued_email
+      expect { }.not_to have_enqueued_email
     end
 
     it "passes when only given mailer argument" do
@@ -82,7 +82,7 @@ def email_with_args(arg1, arg2); end
     end
 
     it "passes when negated with only mailer arguments" do
-      expect {}.not_to have_enqueued_email(TestMailer)
+      expect { }.not_to have_enqueued_email(TestMailer)
     end
 
     it "ensure that the right mailer is enqueued" do
@@ -168,19 +168,19 @@ def email_with_args(arg1, arg2); end
 
     it "generates a failure message when given 0 argument" do
       expect {
-        expect {}.to have_enqueued_mail.at_least(:once)
+        expect { }.to have_enqueued_mail.at_least(:once)
       }.to raise_error(/expected to enqueue ActionMailer::Base at least 1 time but enqueued 0/)
     end
 
     it "generates a failure message when given only mailer argument" do
       expect {
-        expect {}.to have_enqueued_mail(TestMailer).at_least(:once)
+        expect { }.to have_enqueued_mail(TestMailer).at_least(:once)
       }.to raise_error(/expected to enqueue TestMailer at least 1 time but enqueued 0/)
     end
 
     it "generates a failure message with at least hint" do
       expect {
-        expect {}.to have_enqueued_mail(TestMailer, :test_email).at_least(:once)
+        expect { }.to have_enqueued_mail(TestMailer, :test_email).at_least(:once)
       }.to raise_error(/expected to enqueue TestMailer.test_email at least 1 time but enqueued 0/)
     end
 
@@ -225,13 +225,13 @@ def email_with_args(arg1, arg2); end
 
     it "generates a failure message" do
       expect {
-        expect {}.to have_enqueued_email(TestMailer, :test_email)
+        expect { }.to have_enqueued_email(TestMailer, :test_email)
       }.to raise_error(/expected to enqueue TestMailer.test_email/)
     end
 
     it "generates a failure message with arguments" do
       expect {
-        expect {}.to have_enqueued_email(TestMailer, :email_with_args).with(1, 2)
+        expect { }.to have_enqueued_email(TestMailer, :email_with_args).with(1, 2)
       }.to raise_error(/expected to enqueue TestMailer.email_with_args exactly 1 time with \[1, 2\], but enqueued 0/)
     end