Skip to content

Commit 5fad193

Browse files
authored
Merge pull request #2829 from rspec/fix-verify-mailer-preview
Fix build for Rails main, Rails 7.0 and Ruby 3.4
2 parents 6072931 + 7b49919 commit 5fad193

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

Gemfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ gem 'ffi', '> 1.15.5'
1616
gem 'rake', '> 12'
1717
gem 'rubocop', '~> 1.28.2'
1818

19-
if RUBY_VERSION.to_f > 3.3
20-
gem 'cucumber', git: 'https://github.com/cucumber/cucumber-ruby', branch: 'main'
21-
end
22-
2319
custom_gemfile = File.expand_path('Gemfile-custom', __dir__)
2420
eval_gemfile custom_gemfile if File.exist?(custom_gemfile)
2521

Gemfile-rails-dependencies

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ when nil, false, ""
4848
gem 'selenium-webdriver', require: false
4949
else
5050
version_number = version.split(' ').last
51-
add_net_gems_dependency if version_number < '7.0'
51+
52+
gem 'concurrent-ruby', '1.3.4' if version_number < '7.1'
5253

5354
gem "rails", version
5455
gem 'activerecord-jdbcsqlite3-adapter', platforms: [:jruby]

example_app_generator/spec/support/default_preview_path

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ end
77
ENV['RAILS_ENV'] ||= 'development'
88
# Pick the frameworks you want:
99
begin
10+
require "openssl"
1011
require "active_storage"
1112
require "active_storage/engine"
1213
rescue LoadError

example_app_generator/spec/verify_mailer_preview_path_spec.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ def capture_exec(*ops)
4040
CaptureExec.new(out, $?.exitstatus)
4141
end
4242

43-
if ENV['RAILS_VERSION'] == 'main' && Rails::VERSION::STRING == "8.0.0.alpha"
44-
before do
45-
skip('This is broken on Rails main but is skipped for green builds, please fix')
46-
end
47-
end
48-
4943
if Rails::VERSION::STRING.to_f >= 7.1
5044
let(:expected_custom_path) { "/custom/path\n#{::Rails.root}/test/mailers/previews" }
5145
let(:expected_rspec_path) { "#{::Rails.root}/spec/mailers/previews\n#{::Rails.root}/test/mailers/previews" }

0 commit comments

Comments
 (0)