Include rspec:request generator.

This includes a generator for "request" specs. There already exists a
generator which creates these specs, but it is called "integration".
The existing name comes from the legacy implementations attempting to
mirror the Rails test style names for the RSpec equivalent specs.

Since these two generators are identical, except for the name, this
makes the new `RequestGenerator` a subclass of the existing
`IntegrationGenerator`. Alternatively, we could have decided to make
`RequestGenerator` the parent class, moving the existing functionality
into it. While this is arguably the "proper" way of thinking about the
generators, it could potentially break some existing applications; even
though these classes are marked `private`. There's no harm for now in
keeping semver compliant by making this generator additive.

Since the two generators are exactly the same this uses a shared example
to keep the specs in-sync.

Resolve #1377

Author: cupakromer

example_app_generator/generate_stuff.rb

@@ -82,6 +82,7 @@ def using_source_path(path)
 generate('rspec:install')
 generate('controller wombats index') # plural
 generate('controller welcome index') # singular
+generate('rspec:request wombats')
 generate('integration_test widgets')
 generate('mailer Notifications signup')
 

lib/generators/rspec/integration/integration_generator.rb

@@ -4,7 +4,12 @@ module Rspec
   module Generators
     # @private
     class IntegrationGenerator < Base
-      class_option :request_specs,   :type => :boolean, :default => true,  :desc => "Generate request specs"
+      # Add a deprecation for this class, before rspec-rails 4, to use the
+      # `RequestGenerator` instead
+      class_option :request_specs,
+                   :type => :boolean,
+                   :default => true,
+                   :desc => "Generate request specs"
 
       def generate_request_spec
         return unless options[:request_specs]

lib/generators/rspec/request/request_generator.rb

@@ -0,0 +1,10 @@
+require 'generators/rspec/integration/integration_generator'
+
+module Rspec
+  module Generators
+    # @private
+    class RequestGenerator < IntegrationGenerator
+      source_paths << File.expand_path("../../integration/templates", __FILE__)
+    end
+  end
+end

spec/generators/rspec/integration/integration_generator_spec.rb

@@ -1,33 +1,8 @@
-require 'spec_helper'
-
 # Generators are not automatically loaded by Rails
 require 'generators/rspec/integration/integration_generator'
+require 'support/generators'
 
-describe Rspec::Generators::IntegrationGenerator, :type => :generator do
-  # Tell the generator where to put its output (what it thinks of as Rails.root)
-  destination File.expand_path("../../../../../tmp", __FILE__)
-
-  before { prepare_destination }
-
-  describe 'are not generated' do
-    before do
-      run_generator %w(posts --no-request-specs)
-    end
-    describe 'index.html.erb' do
-      subject { file('spec/requests/posts_spec.rb') }
-      it { is_expected.not_to exist }
-    end
-  end
-
-  describe 'are generated' do
-    before do
-      run_generator %w(posts)
-    end
-    subject { file('spec/requests/posts_spec.rb') }
-    it { is_expected.to exist }
-    it { is_expected.to contain(/require 'rails_helper'/) }
-    it { is_expected.to contain(/^RSpec.describe \"Posts\", #{type_metatag(:request)}/) }
-    it { is_expected.to contain(/describe "GET \/posts"/) }
-    it { is_expected.to contain(/get posts_index_path/) }
-  end
+RSpec.describe Rspec::Generators::IntegrationGenerator, :type => :generator do
+  setup_default_destination
+  it_behaves_like "a request spec generator"
 end

spec/generators/rspec/request/request_generator_spec.rb

@@ -0,0 +1,8 @@
+# Generators are not automatically loaded by Rails
+require 'generators/rspec/request/request_generator'
+require 'support/generators'
+
+RSpec.describe Rspec::Generators::RequestGenerator, :type => :generator do
+  setup_default_destination
+  it_behaves_like "a request spec generator"
+end

spec/support/generators.rb

@@ -0,0 +1,73 @@
+module RSpec
+  module Rails
+    module Specs
+      module Generators
+        module Macros
+          # Tell the generator where to put its output (what it thinks of as
+          # Rails.root)
+          def set_default_destination
+            destination File.expand_path("../../../tmp", __FILE__)
+          end
+
+          def setup_default_destination
+            set_default_destination
+            before { prepare_destination }
+          end
+        end
+
+        def self.included(klass)
+          klass.extend(Macros)
+        end
+
+        shared_examples_for "a request spec generator" do
+          describe 'generated with flag `--no-request-specs`' do
+            before do
+              run_generator %w(posts --no-request-specs)
+            end
+
+            subject(:request_spec) { file('spec/requests/posts_spec.rb') }
+
+            it "does not create the request spec" do
+              expect(request_spec).not_to exist
+            end
+          end
+
+          describe 'generated with no flags' do
+            before do
+              run_generator %w(posts)
+            end
+
+            subject(:request_spec) { file('spec/requests/posts_spec.rb') }
+
+            it "creates the request spec" do
+              expect(request_spec).to exist
+            end
+
+            it "the generator requires 'rails_helper'" do
+              expect(request_spec).to contain(/require 'rails_helper'/)
+            end
+
+            it "the generator describes the provided NAME without monkey " \
+               "patching setting the type to `:request`" do
+              expect(request_spec).to contain(
+                /^RSpec.describe \"Posts\", #{type_metatag(:request)}/
+              )
+            end
+
+            it "the generator includes a sample GET request" do
+              expect(request_spec).to contain(/describe "GET \/posts"/)
+            end
+
+            it "the generator sends the GET request to the index path" do
+              expect(request_spec).to contain(/get posts_index_path/)
+            end
+          end
+        end
+      end
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include RSpec::Rails::Specs::Generators, :type => :generator
+end