Fixup response code handling in have_http_status.

This now consistently calls `.to_i` on response codes, which ensures
they're always an integer (accross rails versions). Additionally I
replaced a number of `333` codes with `308`s. The reasoning for this is
that rack no longer accepts non-spec 3xx codes in it's `redirect?`
methods, which breaks our tests.

Author: Sam Phippen

lib/rspec/rails/matchers/have_http_status.rb

@@ -84,7 +84,7 @@ def initialize(code)
           # @return [Boolean] `true` if the numeric code matched the `response` code
           def matches?(response)
             test_response = as_test_response(response)
-            @actual = test_response.response_code
+            @actual = test_response.response_code.to_i
             expected == @actual
           rescue TypeError => _ignored
             @invalid_response = response

spec/rspec/rails/matchers/have_http_status_spec.rb

@@ -382,12 +382,12 @@ def create_response(opts = {})
     it_behaves_like "supports different response instances" do
       subject(:matcher) { have_redirect_status }
 
-      let(:code) { 333 }
+      let(:code) { 308 }
     end
 
     describe "matching a response" do
       it "returns true for a response with a 3xx status code" do
-        any_3xx_code = 333
+        any_3xx_code = 308
         response     = create_response(:status => any_3xx_code)
 
         expect( have_redirect_status.matches?(response) ).to be(true)
@@ -416,12 +416,12 @@ def create_response(opts = {})
     end
 
     it "has a negated failure message reporting the expected and actual status codes" do
-      any_3xx_code = 333
+      any_3xx_code = 308
       response     = create_response(:status => any_3xx_code)
 
       expect{ have_redirect_status.matches? response }.
         to change(have_redirect_status, :failure_message_when_negated).
-        to(/not to have a redirect status code \(3xx\) but it was 333/)
+        to(/not to have a redirect status code \(3xx\) but it was 308/)
     end
   end
 
@@ -430,5 +430,4 @@ def create_response(opts = {})
       expect{ have_http_status(nil) }.to raise_error ArgumentError
     end
   end
-
 end