Skip to content

Commit 80cdc5a

Browse files
authored
Merge pull request #2283 from nsommer/support-symbol-queue-names-in-job-matcher
Support symbol argument in #on_queue
2 parents a9f9093 + 1e4ca2c commit 80cdc5a

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

lib/rspec/rails/matchers/active_job.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def with(*args, &block)
2626
end
2727

2828
def on_queue(queue)
29-
@queue = queue
29+
@queue = queue.to_s
3030
self
3131
end
3232

spec/rspec/rails/matchers/active_job_spec.rb

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,12 +197,18 @@ def self.name; "LoggingJob"; end
197197
}.to raise_error(/expected to enqueue at most 1 jobs, but enqueued 2/)
198198
end
199199

200-
it "passes with provided queue name" do
200+
it "passes with provided queue name as string" do
201201
expect {
202202
hello_job.set(:queue => "low").perform_later
203203
}.to have_enqueued_job.on_queue("low")
204204
end
205205

206+
it "passes with provided queue name as symbol" do
207+
expect {
208+
hello_job.set(:queue => "low").perform_later
209+
}.to have_enqueued_job.on_queue(:low)
210+
end
211+
206212
it "passes with provided at date" do
207213
date = Date.tomorrow.noon
208214
expect {
@@ -531,12 +537,18 @@ def self.name; "LoggingJob"; end
531537
}.to raise_error(/expected to perform at most 1 jobs, but performed 2/)
532538
end
533539

534-
it "passes with provided queue name" do
540+
it "passes with provided queue name as string" do
535541
expect {
536542
hello_job.set(:queue => "low").perform_later
537543
}.to have_performed_job.on_queue("low")
538544
end
539545

546+
it "passes with provided queue name as symbol" do
547+
expect {
548+
hello_job.set(:queue => "low").perform_later
549+
}.to have_performed_job.on_queue(:low)
550+
end
551+
540552
it "passes with provided at date" do
541553
date = Date.tomorrow.noon
542554
expect {

0 commit comments

Comments
 (0)