Skip to content

Commit 89dd9ec

Browse files
committed
Backport skipping of a spec due to Rails bug
Update to the latest released Rails 5.2.4.3 didn't help, it still has the bug. Backported from https://github.com/rspec/rspec-rails/blob/c0a8c22186a1232e3b1612c44bc88052ec56c945/spec/rspec/rails/example/view_example_group_spec.rb#L239
1 parent bed4459 commit 89dd9ec

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

spec/rspec/rails/example/view_example_group_spec.rb

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,19 @@ def controller
218218
expect(view_spec.view).to eq(view)
219219
end
220220

221+
if RUBY_VERSION <= "2.3.0" && ENV["RAILS_VERSION"] !~ /stable/ && ::Rails.version.to_f == 5.2
222+
pending_only_on_ruby_22_rails_52 = """
223+
Rails 5.2.4.2 has a syntax error in ActionDispatch::Request::Session.
224+
(A &. usage which does not work in 2.2.10)
225+
It has been fixed but not released, this spec will not pass until that
226+
has been released.
227+
"""
228+
else
229+
pending_only_on_ruby_22_rails_52 = false
230+
end
231+
221232
# Regression test from rspec/rspec-rails#833
222-
it 'is accessible to configuration-level hooks' do
233+
it 'is accessible to configuration-level hooks', :pending => pending_only_on_ruby_22_rails_52 do
223234
with_isolated_config do
224235
run_count = 0
225236
RSpec.configuration.before(:each, :type => :view) do

0 commit comments

Comments
 (0)