Skip to content

Commit 8ddaeb3

Browse files
babrovkapirj
authored andcommitted
PR comments:
*simplify `eval_gemfile` *remove useless `{}`
1 parent f5c8174 commit 8ddaeb3

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

Gemfile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ RAILS_VERSION = ENV['RAILS_VERSION'] || (File.exist?(version_file) && File.read(
44

55
gemspec
66

7-
rspec_dependencies_gemfile = File.expand_path('Gemfile-rspec-dependencies', __dir__)
8-
eval_gemfile rspec_dependencies_gemfile
7+
eval_gemfile 'Gemfile-rspec-dependencies'
98

109
gem 'yard', '~> 0.8.7', require: false
1110

@@ -63,5 +62,4 @@ gem 'rubocop', '~> 0.79.0'
6362
custom_gemfile = File.expand_path('Gemfile-custom', __dir__)
6463
eval_gemfile custom_gemfile if File.exist?(custom_gemfile)
6564

66-
rails_dependencies_gemfile = File.expand_path('Gemfile-rails-dependencies', __dir__)
67-
eval_gemfile rails_dependencies_gemfile
65+
eval_gemfile 'Gemfile-rails-dependencies'

spec/rspec/rails/view_rendering_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def controller
1616
end
1717

1818
it "does not render views in a nested group" do
19-
expect(group.describe {}.new.render_views?).to be_falsey
19+
expect(group.describe.new.render_views?).to be_falsey
2020
end
2121
end
2222

@@ -76,7 +76,7 @@ def example.controller
7676

7777
context "in a nested group" do
7878
let(:nested_group) do
79-
group.describe {}
79+
group.describe
8080
end
8181

8282
context "with no args" do
@@ -115,7 +115,7 @@ def example.controller
115115
it "passes override to children" do
116116
group.render_views
117117
nested_group.render_views false
118-
expect(nested_group.describe {}.new.render_views?).to be_falsey
118+
expect(nested_group.describe.new.render_views?).to be_falsey
119119
end
120120
end
121121
end

0 commit comments

Comments
 (0)