Enable Layout/DotPosition

Author: babrovka

.rubocop_todo.yml

@@ -1,7 +1,3 @@
-# ruby 1.8.7 required trailing dots
-Layout/DotPosition:
-  EnforcedStyle: trailing
-
 # Over time we'd like to get this down, but this is what we're at now.
 Metrics/CyclomaticComplexity:
   Max: 9 # default: 6

example_app_generator/spec/verify_mailer_preview_path_spec.rb

@@ -19,11 +19,11 @@ def capture_exec(*ops)
     ops << {err: [:child, :out]}
     io = IO.popen(ops)
     # Necessary to ignore warnings from Rails code base
-    out =  io.readlines.
-              reject { |line| line =~ /warning: circular argument reference/ }.
-              reject { |line| line =~ /Gem::Specification#rubyforge_project=/ }.
-              join.
-              chomp
+    out =  io.readlines
+              .reject { |line| line =~ /warning: circular argument reference/ }
+              .reject { |line| line =~ /Gem::Specification#rubyforge_project=/ }
+              .join
+              .chomp
     CaptureExec.new(out, $?.exitstatus)
   end
 

lib/rspec/rails/adapters.rb

@@ -146,9 +146,9 @@ module ClassMethods
         # examples without exposing non-assertion methods in Test::Unit or
         # Minitest.
         def assertion_method_names
-          ::RSpec::Rails::Assertions.
-            public_instance_methods.
-            select do |m|
+          ::RSpec::Rails::Assertions
+            .public_instance_methods
+            .select do |m|
               m.to_s =~ /^(assert|flunk|refute)/
             end
         end

lib/rspec/rails/tasks/rspec.rake

@@ -12,10 +12,10 @@ RSpec::Core::RakeTask.new(spec: "spec:prepare")
 
 namespace :spec do
   types = begin
-            dirs = Dir['./spec/**/*_spec.rb'].
-              map { |f| f.sub(/^\.\/(spec\/\w+)\/.*/, '\\1') }.
-              uniq.
-              select { |f| File.directory?(f) }
+            dirs = Dir['./spec/**/*_spec.rb']
+              .map { |f| f.sub(/^\.\/(spec\/\w+)\/.*/, '\\1') }
+              .uniq
+              .select { |f| File.directory?(f) }
             Hash[dirs.map { |d| [d.split('/').last, d] }]
           end
 

spec/rspec/rails/example/helper_example_group_spec.rb

@@ -67,16 +67,16 @@ def _view
       context "the described is a module" do
         it "returns the module" do
           allow(group).to receive(:described_class) { FoosHelper }
-          expect(group.determine_default_helper_class("ignore this")).
-            to eq(FoosHelper)
+          expect(group.determine_default_helper_class("ignore this"))
+            .to eq(FoosHelper)
         end
       end
 
       context "the described is a class" do
         it "returns nil" do
           allow(group).to receive(:described_class) { FoosHelper::InternalClass }
-          expect(group.determine_default_helper_class("ignore this")).
-            to be_nil
+          expect(group.determine_default_helper_class("ignore this"))
+            .to be_nil
         end
       end
     end

spec/rspec/rails/example/view_example_group_spec.rb

@@ -111,8 +111,8 @@ def self.helper(*); end # Stub method
 
       it "uses routes helpers" do
         allow(::Rails.application).to receive(:routes).and_return(test_routes)
-        expect(view_spec.image_path(double(to_param: "42"))).
-          to eq "/images/42"
+        expect(view_spec.image_path(double(to_param: "42")))
+          .to eq "/images/42"
       end
     end
 
@@ -203,19 +203,19 @@ def _default_file_to_render; end
 
       context "with a common _default_file_to_render" do
         it "it returns the directory" do
-          allow(view_spec).to receive(:_default_file_to_render).
-            and_return("things/new.html.erb")
-          expect(view_spec.__send__(:_controller_path)).
-            to eq("things")
+          allow(view_spec).to receive(:_default_file_to_render)
+            .and_return("things/new.html.erb")
+          expect(view_spec.__send__(:_controller_path))
+            .to eq("things")
         end
       end
 
       context "with a nested _default_file_to_render" do
         it "it returns the directory path" do
-          allow(view_spec).to receive(:_default_file_to_render).
-            and_return("admin/things/new.html.erb")
-          expect(view_spec.__send__(:_controller_path)).
-            to eq("admin/things")
+          allow(view_spec).to receive(:_default_file_to_render)
+            .and_return("admin/things/new.html.erb")
+          expect(view_spec.__send__(:_controller_path))
+            .to eq("admin/things")
         end
       end
     end

spec/rspec/rails/matchers/active_job_spec.rb

@@ -406,8 +406,8 @@ def self.name; "LoggingJob"; end
       future = 1.minute.from_now
       slightly_earlier = 58.seconds.from_now
       heavy_lifting_job.set(wait_until: slightly_earlier).perform_later
-      expect(heavy_lifting_job).
-        to have_been_enqueued.at(a_value_within(5.seconds).of(future))
+      expect(heavy_lifting_job)
+        .to have_been_enqueued.at(a_value_within(5.seconds).of(future))
     end
   end
 

spec/rspec/rails/matchers/have_http_status_spec.rb

@@ -48,17 +48,17 @@ def create_response(opts = { })
     it "has a failure message reporting it was given another type" do
       response = Object.new
 
-      expect { matcher.matches?(response) }.
-        to change(matcher, :failure_message).
-        to("expected a response object, but an instance of Object was received")
+      expect { matcher.matches?(response) }
+        .to change(matcher, :failure_message)
+        .to("expected a response object, but an instance of Object was received")
     end
 
     it "has a negated failure message reporting it was given another type" do
       response = Object.new
 
-      expect { matcher.matches?(response) }.
-        to change(matcher, :failure_message_when_negated).
-        to("expected a response object, but an instance of Object was received")
+      expect { matcher.matches?(response) }
+        .to change(matcher, :failure_message_when_negated)
+        .to("expected a response object, but an instance of Object was received")
     end
   end
 
@@ -91,26 +91,26 @@ def create_response(opts = { })
       any_numeric_code  = 209
       have_numeric_code = have_http_status(any_numeric_code)
 
-      expect(have_numeric_code.description).
-        to eq("respond with numeric status code 209")
+      expect(have_numeric_code.description)
+        .to eq("respond with numeric status code 209")
     end
 
     it "has a failure message reporting the expected and actual status codes" do
       any_numeric_code  = 209
       have_numeric_code = have_http_status(any_numeric_code)
       response          = create_response(status: any_numeric_code + 1)
 
-      expect { have_numeric_code.matches? response }.
-        to change(have_numeric_code, :failure_message).
-        to("expected the response to have status code 209 but it was 210")
+      expect { have_numeric_code.matches? response }
+        .to change(have_numeric_code, :failure_message)
+        .to("expected the response to have status code 209 but it was 210")
     end
 
     it "has a negated failure message reporting the expected status code" do
       any_numeric_code  = 209
       have_numeric_code = have_http_status(any_numeric_code)
 
-      expect(have_numeric_code.failure_message_when_negated).
-        to eq("expected the response not to have status code 209 but it did")
+      expect(have_numeric_code.failure_message_when_negated)
+        .to eq("expected the response not to have status code 209 but it did")
     end
   end
 
@@ -148,26 +148,26 @@ def create_response(opts = { })
       any_symbolic_status  = created_symbolic_status
       have_symbolic_status = have_http_status(any_symbolic_status)
 
-      expect(have_symbolic_status.description).
-        to eq("respond with status code :created (201)")
+      expect(have_symbolic_status.description)
+        .to eq("respond with status code :created (201)")
     end
 
     it "has a failure message reporting the expected and actual statuses" do
       any_symbolic_status  = created_symbolic_status
       have_symbolic_status = have_http_status(any_symbolic_status)
       response             = create_response(status: created_code + 1)
 
-      expect { have_symbolic_status.matches? response }.
-        to change(have_symbolic_status, :failure_message).
-        to("expected the response to have status code :created (201) but it was :accepted (202)")
+      expect { have_symbolic_status.matches? response }
+        .to change(have_symbolic_status, :failure_message)
+        .to("expected the response to have status code :created (201) but it was :accepted (202)")
     end
 
     it "has a negated failure message reporting the expected status code" do
       any_symbolic_status  = created_symbolic_status
       have_symbolic_status = have_http_status(any_symbolic_status)
 
-      expect(have_symbolic_status.failure_message_when_negated).
-        to eq("expected the response not to have status code :created (201) but it did")
+      expect(have_symbolic_status.failure_message_when_negated)
+        .to eq("expected the response not to have status code :created (201) but it did")
     end
 
     it "raises an ArgumentError" do
@@ -207,16 +207,16 @@ def create_response(opts = { })
 
     it "has a failure message reporting the expected and actual status codes" do
       response = create_response(status: other_code)
-      expect { matcher.matches? response }.
-        to change(matcher, :failure_message).
-        to(failure_message)
+      expect { matcher.matches? response }
+        .to change(matcher, :failure_message)
+        .to(failure_message)
     end
 
     it "has a negated failure message reporting the expected and actual status codes" do
       response = create_response(status: expected_code)
-      expect { matcher.matches? response }.
-        to change(matcher, :failure_message_when_negated).
-        to(negated_message)
+      expect { matcher.matches? response }
+        .to change(matcher, :failure_message_when_negated)
+        .to(negated_message)
     end
   end
 

spec/sanity_check_spec.rb

@@ -25,9 +25,9 @@ def with_clean_env
     FileUtils.chmod 0777, script
 
     with_clean_env do
-      expect(`bundle exec #{script} 2>&1`).
-        to match(/uninitialized constant RSpec::Support/).
-        or match(/undefined method `require_rspec_core' for RSpec::Support:Module/)
+      expect(`bundle exec #{script} 2>&1`)
+        .to match(/uninitialized constant RSpec::Support/)
+        .or match(/undefined method `require_rspec_core' for RSpec::Support:Module/)
 
       expect($?.exitstatus).to eq(1)
     end