Skip to content

Commit 98ce767

Browse files
committed
Merge pull request #1479 from rspec/label_Rspec_as_private
Label Rspec as @Private for docs, update other modules visibility
2 parents 3fa4d25 + 4a2a078 commit 98ce767

15 files changed

+14
-1
lines changed

lib/generators/rspec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
require 'rails/generators/named_base'
22
require 'rspec/rails/feature_check'
33

4+
# @private
45
# Weirdly named generators namespace (should be `RSpec`) for compatability with
56
# rails loading.
67
module Rspec

lib/rspec/rails/example/controller_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ module Rails
55
ActionDispatch::Assertions::RoutingAssertions
66
)
77

8+
# @api public
89
# Container module for controller spec functionality.
910
module ControllerExampleGroup
1011
extend ActiveSupport::Concern

lib/rspec/rails/example/feature_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
module RSpec
22
module Rails
3+
# @api public
34
# Container module for routing spec functionality.
45
module FeatureExampleGroup
56
extend ActiveSupport::Concern

lib/rspec/rails/example/helper_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
module RSpec
44
module Rails
5+
# @api public
56
# Container module for helper specs.
67
module HelperExampleGroup
78
extend ActiveSupport::Concern

lib/rspec/rails/example/job_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
module RSpec
22
module Rails
3+
# @api public
34
# Container module for job spec functionality. It is only available if
45
# ActiveJob has been loaded before it.
56
module JobExampleGroup

lib/rspec/rails/example/mailer_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
module RSpec
22
module Rails
3+
# @api public
34
# Container module for mailer spec functionality. It is only available if
45
# ActionMailer has been loaded before it.
56
module MailerExampleGroup

lib/rspec/rails/example/model_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
module RSpec
22
module Rails
3+
# @api public
34
# Container class for model spec functionality. Does not provide anything
45
# special over the common RailsExampleGroup currently.
56
module ModelExampleGroup

lib/rspec/rails/example/rails_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
module RSpec
66
module Rails
7+
# @api public
78
# Common rails example functionality.
89
module RailsExampleGroup
910
extend ActiveSupport::Concern

lib/rspec/rails/example/request_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
module RSpec
22
module Rails
3+
# @api public
34
# Container class for request spec functionality.
45
module RequestExampleGroup
56
extend ActiveSupport::Concern

lib/rspec/rails/example/routing_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ module Rails
77
ActionDispatch::Assertions::RoutingAssertions
88
)
99

10+
# @api public
1011
# Container module for routing spec functionality.
1112
module RoutingExampleGroup
1213
extend ActiveSupport::Concern

lib/rspec/rails/example/view_example_group.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
module RSpec
44
module Rails
5+
# @api public
56
# Container class for view spec functionality.
67
module ViewExampleGroup
78
extend ActiveSupport::Concern

lib/rspec/rails/feature_check.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
# @api private
21
module RSpec
32
module Rails
43
# @private

lib/rspec/rails/matchers.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
module RSpec
66
module Rails
7+
# @api public
78
# Container module for Rails specific matchers.
89
module Matchers
910
end

lib/rspec/rails/matchers/be_valid.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ def failure_message_when_negated
3333
end
3434
end
3535

36+
# @api public
3637
# Passes if the given model instance's `valid?` method is true, meaning
3738
# all of the `ActiveModel::Validations` passed and no errors exist. If a
3839
# message is not given, a default message is shown listing each error.

lib/rspec/rails/view_rendering.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
module RSpec
44
module Rails
5+
# @api public
56
# Helpers for optionally rendering views in controller specs.
67
module ViewRendering
78
extend ActiveSupport::Concern

0 commit comments

Comments
 (0)