Skip to content

Commit 990d410

Browse files
committed
Updated common plaintext files (from rspec-dev) [ci skip]
1 parent aca68a0 commit 990d410

File tree

7 files changed

+84
-43
lines changed

7 files changed

+84
-43
lines changed

.github/FUNDING.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# This file was generated on 2019-11-27T18:54:20+00:00 from the rspec-dev repo.
1+
# This file was generated on 2019-12-05T21:32:23+00:00 from the rspec-dev repo.
22
# DO NOT modify it by hand as your changes will get lost the next time it is generated.
33

44
github: [JonRowe]

BUILD_DETAIL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!---
2-
This file was generated on 2015-12-07T22:01:06+11:00 from the rspec-dev repo.
2+
This file was generated on 2019-12-05T21:32:23+00:00 from the rspec-dev repo.
33
DO NOT modify it by hand as your changes will get lost the next time it is generated.
44
-->
55

@@ -40,7 +40,7 @@ The spec suite performs a couple extra checks that are worth noting:
4040
available for use in any context, we want to minimize how many bits of the standard
4141
library we load and use. Otherwise, RSpec's use of part of the standard library could
4242
mask a problem where a gem author forgets to load a part of the standard library they
43-
rely on. The spec suite contains a spec that defines a whitelist of allowed loaded
43+
rely on. The spec suite contains a spec that defines a list of allowed loaded
4444
stdlibs.
4545

4646
In addition, we use [SimpleCov](https://github.com/colszowka/simplecov)

CODE_OF_CONDUCT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!---
2-
This file was generated on 2015-12-07T22:01:06+11:00 from the rspec-dev repo.
2+
This file was generated on 2019-12-05T21:32:23+00:00 from the rspec-dev repo.
33
DO NOT modify it by hand as your changes will get lost the next time it is generated.
44
-->
55

CONTRIBUTING.md

Lines changed: 12 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!---
2-
This file was generated on 2015-12-07T22:01:06+11:00 from the rspec-dev repo.
2+
This file was generated on 2019-12-05T21:32:23+00:00 from the rspec-dev repo.
33
DO NOT modify it by hand as your changes will get lost the next time it is generated.
44
-->
55

@@ -11,8 +11,8 @@ We welcome contributions from *everyone*. While contributing, please follow the
1111
If you'd like to help make RSpec better, here are some ways you can contribute:
1212

1313
- by running RSpec HEAD to help us catch bugs before new releases
14-
- by [reporting bugs you encounter](https://github.com/rspec/rspec-rails/issues/new?template=bug_report.md)
15-
- by [suggesting new features](https://github.com/rspec/rspec-rails/issues/new?template=feature_request.md)
14+
- by [reporting bugs you encounter](https://github.com/rspec/rspec-rails/issues/new) with [report template](#report-template)
15+
- by [suggesting new features](https://github.com/rspec/rspec-rails/issues/new)
1616
- by improving RSpec's [Relish](https://relishapp.com/rspec) or [API](https://rspec.info/documentation/) documentation
1717
- by improving [RSpec's website](https://rspec.info/) ([source](https://github.com/rspec/rspec.github.io))
1818
- by taking part in [feature and issue discussions](https://github.com/rspec/rspec-rails/issues)
@@ -24,47 +24,21 @@ If you need help getting started, check out the [DEVELOPMENT](DEVELOPMENT.md) fi
2424

2525
Thanks for helping us make RSpec better!
2626

27-
## Rspec issues labels definition
27+
## `Small` issues
2828

29-
### `Your first PR` issues
29+
These issue are ones that we be believe are best suited for new contributors to
30+
get started with. They represent a meaningful contribution to the project that
31+
should not be too hard to pull off.
3032

31-
These issues are the ones that we be believe are best suited for new
32-
contributors to get started on. They represent a potential meaningful
33-
contribution to the project that should not be too hard to pull off.
33+
## Report template
3434

35-
### `Needs reproduction case` issues
36-
37-
These issues are ones that have been labelled by the maintainers that we
38-
believe do not currently have enough information to be reproduced the RSpec
39-
team. While not directly counted by the GitHub contribution graph, we consider
40-
helping us to reproduce the issue with a repro case as an extremely meaningful
41-
contribution.
42-
43-
### `Has reproduction case` issues
44-
45-
These issues are the ones that have reproduction cases, able to start working on
46-
immediately. These are good ones to tackle to help us actively fix bugs.
35+
Having a way to reproduce your issue will be very helpful for others to help confirm,
36+
investigate and ultimately fix your issue. You can do this by providing an executable
37+
test case. To make this process easier, we have prepared one basic
38+
[bug report templates](REPORT_TEMPLATE.md) for you to use as a starting point.
4739

4840
## Maintenance branches
4941

5042
Maintenance branches are how we manage the different supported point releases
5143
of RSpec. As such, while they might look like good candidates to merge into
5244
master, please do not open pull requests to merge them.
53-
54-
## How do the cukes work?
55-
56-
The cucumber features for RSpec rails document how it works, but are also quasi
57-
executable tests for the framework. They execute in the context of a pre-setup
58-
Rails app.
59-
60-
1. Before the cucumber specs run, the directory `tmp/aruba` is cleared
61-
2. If the example app hasn't already been created,
62-
`bundle exec rake generate:app generate:stuff` is executed.
63-
3. The example app is copied in to `tmp/aruba`
64-
4. Everything in `tmp/aruba/spec/*` is deleted apart from `spec/spec_helper.rb` and
65-
`spec/rails_helper.rb`
66-
5. the cucumber suite executes, creating files in that app and executing them
67-
68-
The best way to debug the app is to run a failing cucumber feature, which will
69-
leave the test files intact in `tmp/aruba`, then you can cd in to that director
70-
and run it in the bundle context of the aruba app.

DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!---
2-
This file was generated on 2015-12-07T22:01:06+11:00 from the rspec-dev repo.
2+
This file was generated on 2019-12-05T21:32:23+00:00 from the rspec-dev repo.
33
DO NOT modify it by hand as your changes will get lost the next time it is generated.
44
-->
55

ISSUE_TEMPLATE.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
### Subject of the issue
2+
<!---
3+
Describe your issue here.
4+
-->
5+
6+
### Your environment
7+
* Ruby version:
8+
* rspec-rails version:
9+
10+
### Steps to reproduce
11+
<!---
12+
Tell us how to reproduce this issue. Please provide a working demo, you can use
13+
this [templates](REPORT_TEMPLATE.md) as a base.
14+
-->
15+
16+
### Expected behavior
17+
<!---
18+
Tell us what should happen.
19+
-->
20+
21+
### Actual behavior
22+
<!---
23+
Tell us what happens instead.
24+
-->

REPORT_TEMPLATE.md

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<!---
2+
This file was generated on 2019-12-05T21:32:23+00:00 from the rspec-dev repo.
3+
DO NOT modify it by hand as your changes will get lost the next time it is generated.
4+
-->
5+
6+
# Report template
7+
8+
```ruby
9+
# frozen_string_literal: true
10+
11+
begin
12+
require "bundler/inline"
13+
rescue LoadError => e
14+
$stderr.puts "Bundler version 1.10 or later is required. Please update your Bundler"
15+
raise e
16+
end
17+
18+
gemfile(true) do
19+
source "https://rubygems.org"
20+
21+
gem "rspec", "3.7.0" # Activate the gem and version you are reporting the issue against.
22+
end
23+
24+
puts "Ruby version is: #{RUBY_VERSION}"
25+
require 'rspec/autorun'
26+
27+
RSpec.describe 'additions' do
28+
it 'returns 2' do
29+
expect(1 + 1).to eq(2)
30+
end
31+
32+
it 'returns 1' do
33+
expect(3 - 1).to eq(-1)
34+
end
35+
end
36+
```
37+
38+
Simply copy the content of the appropriate template into a `.rb` file on your computer
39+
and make the necessary changes to demonstrate the issue. You can execute it by running
40+
`ruby rspec_report.rb` in your terminal.
41+
42+
You can then share your executable test case as a [gist](https://gist.github.com), or
43+
simply paste the content into the issue description.

0 commit comments

Comments
 (0)