Prevent ActiveJob::DeserializationError when deserialising expired jobs (#2036)

Prevents an exception from being raised when looking for an ActiveJob with specific arguments if one or more of the active jobs in the queue have arguments that cannot be deserialised (e.g. if the record has now been deleted).

Author: aymeric-ledorze

lib/rspec/rails/matchers/active_job.rb

@@ -98,7 +98,7 @@ def supports_block_expectations?
           def check(jobs)
             @matching_jobs, @unmatching_jobs = jobs.partition do |job|
               if arguments_match?(job) && other_attributes_match?(job)
-                args = ::ActiveJob::Arguments.deserialize(job[:args])
+                args = deserialize_arguments(job)
                 @block.call(*args)
                 true
               else
@@ -125,7 +125,7 @@ def base_message
 
           def base_job_message(job)
             msg_parts = []
-            msg_parts << "with #{::ActiveJob::Arguments.deserialize(job[:args])}" if job[:args].any?
+            msg_parts << "with #{deserialize_arguments(job)}" if job[:args].any?
             msg_parts << "on queue #{job[:queue]}" if job[:queue]
             msg_parts << "at #{Time.at(job[:at])}" if job[:at]
 
@@ -136,7 +136,7 @@ def base_job_message(job)
 
           def arguments_match?(job)
             if @args.any?
-              deserialized_args = ::ActiveJob::Arguments.deserialize(job[:args])
+              deserialized_args = deserialize_arguments(job)
               RSpec::Mocks::ArgumentListMatcher.new(*@args).args_match?(*deserialized_args)
             else
               true
@@ -169,6 +169,12 @@ def set_expected_number(relativity, count)
                                end
           end
 
+          def deserialize_arguments(job)
+            ::ActiveJob::Arguments.deserialize(job[:args])
+          rescue ::ActiveJob::DeserializationError
+            job[:args]
+          end
+
           def queue_adapter
             ::ActiveJob::Base.queue_adapter
           end

spec/rspec/rails/matchers/active_job_spec.rb

@@ -18,13 +18,19 @@ def initialize(id)
     end
 
     def ==(comparison_object)
-      id == comparison_object.id
+      (GlobalIdModel === comparison_object) && (id == comparison_object.id)
     end
 
     def to_global_id(options = {})
       @global_id ||= GlobalID.create(self, :app => "rspec-suite")
     end
   end
+
+  class FailingGlobalIdModel < GlobalIdModel
+    def self.find(id)
+      raise URI::GID::MissingModelIdError
+    end
+  end
 end
 
 RSpec.describe "ActiveJob matchers", :skip => !RSpec::Rails::FeatureCheck.has_active_job? do
@@ -293,6 +299,16 @@ def self.name; "LoggingJob"; end
       }
     end
 
+    it "ignores undeserializable arguments" do
+      failing_global_id_object = FailingGlobalIdModel.new("21")
+      global_id_object = GlobalIdModel.new("42")
+
+      expect{
+        hello_job.perform_later(failing_global_id_object)
+        hello_job.perform_later(global_id_object)
+      }.to have_enqueued_job(hello_job).with(global_id_object)
+    end
+
     it "only calls with block if other conditions are met" do
       noon = Date.tomorrow.noon
       midnight = Date.tomorrow.midnight