Favor request specs over controller specs for rails g controller

Solves Issue #2056

Author: klyonrad

lib/generators/rspec/controller/controller_generator.rb

@@ -7,10 +7,22 @@ class ControllerGenerator < Base
       argument :actions, :type => :array, :default => [], :banner => "action action"
 
       class_option :template_engine, :desc => "Template engine to generate view files"
-      class_option :controller_specs, :type => :boolean, :default => true, :desc => "Generate controller specs"
+      if Rails.version.to_f >= 5.0
+        class_option :request_specs,    :type => :boolean, :default => true, :desc => "Generate request specs"
+        class_option :controller_specs, :type => :boolean, :default => false, :desc => "Generate controller specs"
+      else
+        class_option :controller_specs, :type => :boolean, :default => true, :desc => "Generate controller specs"
+      end
       class_option :view_specs,       :type => :boolean, :default => true, :desc => "Generate view specs"
       class_option :routing_specs,    :type => :boolean, :default => false, :desc => "Generate routing specs"
 
+      def generate_request_spec
+        return unless options[:request_specs]
+
+        template 'request_spec.rb',
+                 File.join('spec/requests', class_path, "#{file_name}_request_spec.rb")
+      end
+
       def generate_controller_spec
         return unless options[:controller_specs]
 

lib/generators/rspec/controller/templates/request_spec.rb

@@ -0,0 +1,10 @@
+require 'rails_helper'
+
+RSpec.describe "<%= class_name.pluralize %>", <%= type_metatag(:request) %> do
+  describe "GET /<%= name.underscore.pluralize %>" do
+    it "works! (now write some real specs)" do
+      get <%= index_helper %>_path
+      expect(response).to have_http_status(200)
+    end
+  end
+end

spec/generators/rspec/controller/controller_generator_spec.rb

@@ -5,23 +5,29 @@
 RSpec.describe Rspec::Generators::ControllerGenerator, :type => :generator do
   setup_default_destination
 
-  describe 'controller specs' do
-    subject { file('spec/controllers/posts_controller_spec.rb') }
-    describe 'generated by default' do
-      before do
-        run_generator %w(posts)
-      end
+  describe 'request specs' do
+    subject { file('spec/requests/posts_request_spec.rb') }
 
-      describe 'the spec' do
-        it { is_expected.to exist }
-        it { is_expected.to contain(/require 'rails_helper'/) }
-        it { is_expected.to contain(/^RSpec.describe PostsController, #{type_metatag(:controller)}/) }
+    if Rails.version.to_f >= 5.0
+      describe 'generated by default' do
+        before do
+          run_generator %w[posts]
+        end
+
+        describe 'the spec' do
+          it { is_expected.to exist }
+          it { is_expected.to contain(/require 'rails_helper'/) }
+          it { is_expected.to contain(/^RSpec.describe "Posts", #{type_metatag(:request)}/) }
+        end
       end
-    end
-    describe 'skipped with a flag' do
-      before do
-        run_generator %w(posts --no-controller_specs)
+
+      describe 'skipped with a flag' do
+        before do
+          run_generator %w[posts --no-request_specs]
+        end
+        it { is_expected.not_to exist }
       end
+    else
       it { is_expected.not_to exist }
     end
   end
@@ -127,4 +133,52 @@
       it { is_expected.not_to exist }
     end
   end
+
+  describe 'controller specs' do
+    subject { file('spec/controllers/posts_controller_spec.rb') }
+
+    if Rails.version.to_f < 5.0
+      describe 'generated by default' do
+        before do
+          run_generator %w[posts]
+        end
+
+        describe 'the spec' do
+          it { is_expected.to exist }
+          it { is_expected.to contain(/require 'rails_helper'/) }
+          it { is_expected.to contain(/^RSpec.describe PostsController, #{type_metatag(:controller)}/) }
+        end
+      end
+
+      describe 'skipped with a flag' do
+        before do
+          run_generator %w[posts --no-controller-specs]
+        end
+        it { is_expected.not_to exist }
+      end
+    else
+      describe 'are not generated' do
+        it { is_expected.not_to exist }
+      end
+
+      describe 'with --controller-specs flag' do
+        before do
+          run_generator %w[posts --controller-specs]
+        end
+
+        describe 'the spec' do
+          it { is_expected.to exist }
+          it { is_expected.to contain(/require 'rails_helper'/) }
+          it { is_expected.to contain(/^RSpec.describe PostsController, #{type_metatag(:controller)}/) }
+        end
+      end
+
+      describe 'with --no-controller_specs flag' do
+        before do
+          run_generator %w[posts --no-controller-specs]
+        end
+        it { is_expected.not_to exist }
+      end
+    end
+  end
 end