Merge pull request #1534 from rspec/use-same-version-of-nokogiri-in-example-app

Use the same version of nokogiri in example app

Author: Sam Phippen

.travis.yml

@@ -104,6 +104,8 @@ matrix:
     - rvm: 2.3.0
       env: RAILS_VERSION='~> 3.1.12'
   allow_failures:
+    - rvm: 1.8.7
+      env: RAILS_VERSION='~> 3.2.17'
     - rvm: 2.2.2
       env: RAILS_VERSION=master
     - rvm: 2.3.0

example_app_generator/generate_app.rb

@@ -1,3 +1,5 @@
+require 'nokogiri/version'
+
 rspec_rails_repo_path = File.expand_path("../../", __FILE__)
 rspec_dependencies_gemfile = File.join(rspec_rails_repo_path, 'Gemfile-rspec-dependencies')
 rails_dependencies_gemfile = File.join(rspec_rails_repo_path, 'Gemfile-rails-dependencies')
@@ -18,9 +20,13 @@
   gsub_file "Gemfile", /.*debugger.*/, ''
 
   if Rails::VERSION::STRING >= '5.0.0'
-    append_to_file('Gemfile', "gem 'rails-controller-testing', :git => 'https://github.com/rails/rails-controller-testing'")
+    append_to_file('Gemfile', "gem 'rails-controller-testing', :git => 'https://github.com/rails/rails-controller-testing'\n")
   end
 
+  # Nokogiri version is pinned in rspec-rails' Gemfile since it tend to cause installation problems
+  # on Travis CI, so we pin nokogiri in this example app also.
+  append_to_file 'Gemfile', "gem 'nokogiri', '#{Nokogiri::VERSION}'\n"
+
   # Use our version of RSpec and Rails
   append_to_file 'Gemfile', <<-EOT.gsub(/^ +\|/, '')
     |# Rack::Cache 1.3.0 requires Ruby >= 2.0.0