Skip to content

Commit b1aab4f

Browse files
committed
Update cucumber
cucumber 4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it cucumber 3.2 would run on Ruby 2.2, 2.3 and 2.4 Sibling PRs: - rspec/rspec-core#2877 - rspec/rspec-mocks#1439 - rspec/rspec-expectations#1320
1 parent d2a9e0e commit b1aab4f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Rakefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ Cucumber::Rake::Task.new(:cucumber) do |t|
3333
tags = []
3434

3535
if version.to_f >= 6.0
36-
tags << "~@rails_pre_6"
36+
tags << "'not @rails_pre_6'"
3737
end
3838

3939
if version.to_f < 6.0
40-
tags << "~@rails_post_6"
40+
tags << "'not @rails_post_6'"
4141
end
4242

4343
cucumber_flag = tags.map { |tag| "--tag #{tag}" }

cucumber.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
default: --require features --format progress --tags ~@wip
2-
pretty: --require features --format pretty --tags ~@wip
1+
default: --require features --format progress --tags 'not @wip'
2+
pretty: --require features --format pretty --tags 'not @wip'
33
wip: --require features --tags @wip

rspec-rails.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,5 @@ Gem::Specification.new do |s|
5858

5959
s.add_development_dependency 'ammeter', '~> 1.1.5'
6060
s.add_development_dependency 'aruba', '~> 0.14.12'
61-
s.add_development_dependency 'cucumber', '~> 1.3.5'
61+
s.add_development_dependency 'cucumber', '>= 3.2', '!= 4.0.0', '< 8.0.0'
6262
end

0 commit comments

Comments
 (0)