Merge pull request #1499 from rspec/fix-helper-specs-with-internal-classes

Fix helper specs with internal classes

Author: Sam Phippen

lib/rspec/rails/example/helper_example_group.rb

@@ -12,8 +12,15 @@ module HelperExampleGroup
 
       # @private
       module ClassMethods
-        def determine_default_helper_class(_ignore)
-          described_class
+        if ::Rails::VERSION::MAJOR > 3
+          def determine_constant_from_test_name(_ignore)
+            described_class if yield(described_class)
+          end
+        else
+          def determine_default_helper_class(_ignore)
+            return unless Module === described_class && !(Class === described_class)
+            described_class
+          end
         end
       end
 

spec/rspec/rails/example/helper_example_group_spec.rb

@@ -2,7 +2,11 @@
 
 module RSpec::Rails
   describe HelperExampleGroup do
-    module ::FoosHelper; end
+    module ::FoosHelper
+      class InternalClass
+      end
+    end
+
     subject { HelperExampleGroup }
 
     it_behaves_like "an rspec-rails example group mixin", :helper,
@@ -48,11 +52,26 @@ def _view
 
   describe HelperExampleGroup::ClassMethods do
     describe "determine_default_helper_class" do
-      it "returns the helper module passed to describe" do
-        helper_spec = Object.new.extend HelperExampleGroup::ClassMethods
-        allow(helper_spec).to receive(:described_class) { FoosHelper }
-        expect(helper_spec.determine_default_helper_class("ignore this")).
-          to eq(FoosHelper)
+      let(:group) do
+        RSpec::Core::ExampleGroup.describe do
+          include HelperExampleGroup
+        end
+      end
+
+      context "the described is a module" do
+        it "returns the module" do
+          allow(group).to receive(:described_class) { FoosHelper }
+          expect(group.determine_default_helper_class("ignore this")).
+            to eq(FoosHelper)
+        end
+      end
+
+      context "the described is a class" do
+        it "returns nil" do
+          allow(group).to receive(:described_class) { FoosHelper::InternalClass }
+          expect(group.determine_default_helper_class("ignore this")).
+            to be_nil
+        end
       end
     end
   end