Skip to content

Commit b634f35

Browse files
committed
Update feature test with PR feedback
1 parent f044207 commit b634f35

File tree

1 file changed

+2
-42
lines changed

1 file changed

+2
-42
lines changed
Lines changed: 2 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Feature: engine named routes
22

3-
Generated requeset specs inside a Rails Engine is able to use route and url helpers.
3+
Request specs inside a Rails Engine can include the engines routes to use url helpers.
44

5-
Scenario: include engine route helpers
5+
Scenario: using engine route helpers
66
Given a file named "spec/requests/widgets_spec.rb" with:
77
"""ruby
88
require "rails_helper"
@@ -30,7 +30,6 @@ Feature: engine named routes
3030
3131
module MyEngine
3232
RSpec.describe "Links", :type => :request do
33-
3433
include Engine.routes.url_helpers
3534
3635
it "redirects to a random widget" do
@@ -42,42 +41,3 @@ Feature: engine named routes
4241
"""
4342
When I run `rspec spec`
4443
Then the example should pass
45-
46-
Scenario: do not include engine route helpers
47-
Given a file named "spec/requests/widgets_spec.rb" with:
48-
"""ruby
49-
require "rails_helper"
50-
51-
# A very simple Rails engine
52-
module MyEngine
53-
class Engine < ::Rails::Engine
54-
isolate_namespace MyEngine
55-
end
56-
57-
class LinksController < ::ActionController::Base
58-
def index
59-
render plain: 'hit_engine_route'
60-
end
61-
end
62-
end
63-
64-
MyEngine::Engine.routes.draw do
65-
resources :links, :only => [:index]
66-
end
67-
68-
Rails.application.routes.draw do
69-
mount MyEngine::Engine => "/my_engine"
70-
end
71-
72-
module MyEngine
73-
RSpec.describe "Links", :type => :request do
74-
75-
it "redirects to a random widget" do
76-
get links_url
77-
expect(response.body).to eq('hit_engine_route')
78-
end
79-
end
80-
end
81-
"""
82-
When I run `rspec spec`
83-
Then the example should fail

0 commit comments

Comments
 (0)