Turn on partial double verification in specs

Author: pirj

spec/rspec/rails/configuration_spec.rb

@@ -196,7 +196,8 @@ def in_inferring_type_from_location_environment
   it "metadata `type: :request` sets up request example groups" do
     a_rails_app = double("Rails application")
     the_rails_module = Module.new {
-      def self.version; end;
+      def self.version; end
+      def self.application; end
     }
     allow(the_rails_module).to receive(:application) { a_rails_app }
     version = ::Rails::VERSION
@@ -232,7 +233,8 @@ def self.version; end;
   it "metadata `type: :feature` sets up feature example groups" do
     a_rails_app = double("Rails application")
     the_rails_module = Module.new {
-      def self.version; end;
+      def self.version; end
+      def self.application; end
     }
     allow(the_rails_module).to receive(:application) { a_rails_app }
     version = ::Rails::VERSION

spec/rspec/rails/example/controller_example_group_spec.rb

@@ -60,12 +60,11 @@ def my_helper
       let(:controller) { double('controller') }
       let(:example) { group.new }
       let(:routes) do
-        routes = nil
         with_isolated_stderr do
           routes = ActionDispatch::Routing::RouteSet.new
           routes.draw { resources :foos }
+          routes
         end
-        routes
       end
 
       before do
@@ -84,7 +83,6 @@ def my_helper
 
       it "calls NamedRouteCollection#route_defined? when it checks that given route is defined or not" do
         expect(routes.named_routes).to receive(:route_defined?).and_return(true)
-        expect(routes.named_routes).not_to receive(:helpers)
 
         example.foos_url
       end

spec/rspec/rails/example/helper_example_group_spec.rb

@@ -20,12 +20,14 @@ class InternalClass
 
     describe "#helper" do
       it "returns the instance of AV::Base provided by AV::TC::Behavior" do
-        helper_spec = Object.new.extend HelperExampleGroup
-        expect(helper_spec).to receive(:view_assigns)
-        av_tc_b_view = double('_view')
-        expect(av_tc_b_view).to receive(:assign)
-        allow(helper_spec).to receive(:_view) { av_tc_b_view }
-        expect(helper_spec.helper).to eq(av_tc_b_view)
+        without_partial_double_verification do
+          helper_spec = Object.new.extend HelperExampleGroup
+          expect(helper_spec).to receive(:view_assigns)
+          av_tc_b_view = double('_view')
+          expect(av_tc_b_view).to receive(:assign)
+          allow(helper_spec).to receive(:_view) { av_tc_b_view }
+          expect(helper_spec.helper).to eq(av_tc_b_view)
+        end
       end
 
       before do

spec/rspec/rails/example/view_example_group_spec.rb

@@ -8,15 +8,19 @@ module ::ThingsHelper; end
       module ::Namespaced; module ThingsHelper; end; end
 
       it 'includes the helper with the same name' do
-        group = RSpec::Core::ExampleGroup.describe 'things/show.html.erb'
+        group = RSpec::Core::ExampleGroup.describe('things/show.html.erb') do
+          def self.helper(*); end # Stub method
+        end
         expect(group).to receive(:helper).with(ThingsHelper)
         group.class_exec do
           include ViewExampleGroup
         end
       end
 
       it 'includes the namespaced helper with the same name' do
-        group = RSpec::Core::ExampleGroup.describe 'namespaced/things/show.html.erb'
+        group = RSpec::Core::ExampleGroup.describe('namespaced/things/show.html.erb') do
+          def self.helper(*); end # Stub method
+        end
         expect(group).to receive(:helper).with(Namespaced::ThingsHelper)
         group.class_exec do
           include ViewExampleGroup
@@ -56,7 +60,9 @@ module ::ApplicationHelper; end
         end
 
         it 'includes the application helper' do
-          group = RSpec::Core::ExampleGroup.describe 'bars/new.html.erb'
+          group = RSpec::Core::ExampleGroup.describe('bars/new.html.erb') do
+            def self.helper(*); end # Stub method
+          end
           expect(group).to receive(:helper).with(ApplicationHelper)
           group.class_exec do
             include ViewExampleGroup
@@ -124,6 +130,7 @@ def _assigns
             end
           end
           include local
+          def _default_file_to_render; end # Stub method
           include ViewExampleGroup::ExampleMethods
         end.new
       end
@@ -174,7 +181,7 @@ def _assigns
         Class.new do
           include ViewExampleGroup::ExampleMethods
           def controller
-            @controller ||= Object.new
+            @controller ||= OpenStruct.new(params: nil)
           end
         end.new
       end
@@ -189,8 +196,10 @@ def controller
       let(:view_spec) do
         Class.new do
           include ViewExampleGroup::ExampleMethods
+          def _default_file_to_render; end
         end.new
       end
+
       context "with a common _default_file_to_render" do
         it "it returns the directory" do
           allow(view_spec).to receive(:_default_file_to_render).
@@ -213,6 +222,7 @@ def controller
     describe "#view" do
       let(:view_spec) do
         Class.new do
+          def _view; end # Stub method
           include ViewExampleGroup::ExampleMethods
         end.new
       end
@@ -227,13 +237,13 @@ def controller
         with_isolated_config do
           run_count = 0
           RSpec.configuration.before(:each, :type => :view) do
-            allow(view).to receive(:a_stubbed_helper) { :value }
+            allow(view).to receive(:render) { :value }
             run_count += 1
           end
           group = RSpec::Core::ExampleGroup.describe 'a view', :type => :view do
             specify { true }
           end
-          group.run NullObject.new
+          group.run
           expect(run_count).to eq 1
         end
       end

spec/rspec/rails/matchers/have_rendered_spec.rb

@@ -4,20 +4,23 @@
     let(:response) { ActionDispatch::TestResponse.new }
 
     context "given a hash" do
+      def assert_template(*); end
       it "delegates to assert_template" do
         expect(self).to receive(:assert_template).with({:this => "hash"}, "this message")
         expect("response").to send(template_expectation, {:this => "hash"}, "this message")
       end
     end
 
     context "given a string" do
+      def assert_template(*); end
       it "delegates to assert_template" do
         expect(self).to receive(:assert_template).with("this string", "this message")
         expect("response").to send(template_expectation, "this string", "this message")
       end
     end
 
     context "given a symbol" do
+      def assert_template(*); end
       it "converts to_s and delegates to assert_template" do
         expect(self).to receive(:assert_template).with("template_name", "this message")
         expect("response").to send(template_expectation, :template_name, "this message")
@@ -26,8 +29,8 @@
 
     context "with should" do
       context "when assert_template passes" do
+        def assert_template(*); end
         it "passes" do
-          def assert_template(*); end
           expect do
             expect(response).to send(template_expectation, "template_name")
           end.to_not raise_exception

spec/rspec/rails/setup_and_teardown_adapter_spec.rb

@@ -1,47 +1,47 @@
 RSpec.describe RSpec::Rails::SetupAndTeardownAdapter do
-  describe "::setup" do
+  describe ".setup" do
     it "registers before hooks in the order setup is received" do
-      klass = Class.new do
+      group = RSpec::Core::ExampleGroup.describe do
         include RSpec::Rails::SetupAndTeardownAdapter
         def self.foo; "foo"; end
         def self.bar; "bar"; end
       end
-      expect(klass).to receive(:before).ordered { |&block| expect(block.call).to eq "foo" }
-      expect(klass).to receive(:before).ordered { |&block| expect(block.call).to eq "bar" }
-      expect(klass).to receive(:before).ordered { |&block| expect(block.call).to eq "baz" }
+      expect(group).to receive(:before).ordered { |&block| expect(block.call).to eq "foo" }
+      expect(group).to receive(:before).ordered { |&block| expect(block.call).to eq "bar" }
+      expect(group).to receive(:before).ordered { |&block| expect(block.call).to eq "baz" }
 
-      klass.setup :foo
-      klass.setup :bar
-      klass.setup { "baz" }
+      group.setup :foo
+      group.setup :bar
+      group.setup { "baz" }
     end
 
     it "registers prepend_before hooks for the Rails' setup methods" do
-      klass = Class.new do
+      group = RSpec::Core::ExampleGroup.describe do
         include RSpec::Rails::SetupAndTeardownAdapter
         def self.setup_fixtures; "setup fixtures"  end
         def self.setup_controller_request_and_response; "setup controller"  end
       end
 
-      expect(klass).to receive(:prepend_before) { |&block| expect(block.call).to eq "setup fixtures" }
-      expect(klass).to receive(:prepend_before) { |&block| expect(block.call).to eq "setup controller" }
+      expect(group).to receive(:prepend_before) { |&block| expect(block.call).to eq "setup fixtures" }
+      expect(group).to receive(:prepend_before) { |&block| expect(block.call).to eq "setup controller" }
 
-      klass.setup :setup_fixtures
-      klass.setup :setup_controller_request_and_response
+      group.setup :setup_fixtures
+      group.setup :setup_controller_request_and_response
     end
 
     it "registers teardown hooks in the order setup is received" do
-      klass = Class.new do
+      group = RSpec::Core::ExampleGroup.describe do
         include RSpec::Rails::SetupAndTeardownAdapter
         def self.foo; "foo"; end
         def self.bar; "bar"; end
       end
-      expect(klass).to receive(:after).ordered { |&block| expect(block.call).to eq "foo" }
-      expect(klass).to receive(:after).ordered { |&block| expect(block.call).to eq "bar" }
-      expect(klass).to receive(:after).ordered { |&block| expect(block.call).to eq "baz" }
+      expect(group).to receive(:after).ordered { |&block| expect(block.call).to eq "foo" }
+      expect(group).to receive(:after).ordered { |&block| expect(block.call).to eq "bar" }
+      expect(group).to receive(:after).ordered { |&block| expect(block.call).to eq "baz" }
 
-      klass.teardown :foo
-      klass.teardown :bar
-      klass.teardown { "baz" }
+      group.teardown :foo
+      group.teardown :bar
+      group.teardown { "baz" }
     end
   end
 end

spec/spec_helper.rb

@@ -33,7 +33,7 @@ def self.run_all(reporter=nil)
   end
 
   config.mock_with :rspec do |mocks|
-    # mocks.verify_partial_doubles = true
+    mocks.verify_partial_doubles = true
     mocks.verify_doubled_constant_names = true
   end