Merge pull request #2173 from rspec/fix-build

Pin minitest on older Rubies

Author: JonRowe

Gemfile

@@ -47,6 +47,10 @@ if RUBY_VERSION < '2.0.0'
   gem 'mime-types', '< 3'
 end
 
+# Version 5.12 of minitest requires Ruby 2.4
+if RUBY_VERSION < '2.4.0'
+  gem 'minitest', '< 5.12.0'
+end
 
 # Capybara versions that support RSpec 3 only support RUBY_VERSION >= 1.9.3
 if RUBY_VERSION >= '1.9.3'

script/functions.sh

@@ -72,7 +72,7 @@ function run_specs_one_by_one {
 
   for file in `find spec -iname '*_spec.rb'`; do
     echo "Running $file"
-    bin/rspec $file -b --format progress
+    bin/rspec $file --format progress
   done
 }
 

script/predicate_functions.sh

@@ -33,6 +33,18 @@ function is_mri_192 {
   fi
 }
 
+function is_mri_193 {
+  if is_mri; then
+    if ruby -e "exit(RUBY_VERSION == '1.9.3')"; then
+      return 0
+    else
+      return 1
+    fi
+  else
+    return 1
+  fi
+}
+
 function is_mri_192_plus {
   if is_mri; then
     if ruby -e "exit(RUBY_VERSION.to_f > 1.8)"; then

script/run_build

@@ -29,7 +29,11 @@ if style_and_lint_enforced; then
 fi
 
 if is_mri; then
-  fold "one-by-one specs" run_specs_one_by_one
+  # As of 2019-09-24 this causes a huge log due to a cicular dependency
+  # disable for now
+  if !is_mri_193; then
+    fold "one-by-one specs" run_specs_one_by_one
+  fi
   run_all_spec_suites
 else
   echo "Skipping the rest of the build on non-MRI rubies"