Skip to content

Commit e1c36a5

Browse files
committed
Lock sprockets to 3.x on Ruby < 2.5
Sprockets 4.0 depend on Ruby >= 2.5 https://rubygems.org/gems/sprockets/versions/4.0.0 This results in build failures (https://travis-ci.org/github/rspec/rspec-rails/jobs/713253057): Installing sprockets 4.0.2 Gem::RuntimeRequirementNotMetError: sprockets requires Ruby version >= 2.5.0. The current ruby version is 2.4.10.364. This is a forgotten forward-port from https://github.com/rspec/rspec-rails/pull/2360/files#diff-8c3955be04b733dbd31e54e50844fb84R31 Surprisingly, Ruby 2.3.8 and Ruby 2.2.10 builds don't fail, and install sprockets 3.7.2.
1 parent 60dc9c4 commit e1c36a5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Gemfile-rails-dependencies

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ when /stable$/
1818
gem_list = %w[rails railties actionmailer actionpack activerecord activesupport activejob actionview]
1919
gem 'puma', "3.12.1" if version > '5-0-stable'
2020
gem 'activerecord-jdbcsqlite3-adapter', git: 'https://github.com/jruby/activerecord-jdbc-adapter', platforms: [:jruby]
21+
gem "sprockets", '~> 3.0' if RUBY_VERSION < '2.5'
2122

2223
gem_list.each do |rails_gem|
2324
gem rails_gem, :git => "https://github.com/rails/rails.git", :branch => version
@@ -28,7 +29,7 @@ when nil, false, ""
2829
gem 'activerecord-jdbcsqlite3-adapter', platforms: [:jruby]
2930
else
3031
gem "rails", version
31-
32+
gem "sprockets", '~> 3.0' if RUBY_VERSION < '2.5'
3233
gem "puma" if version >= '5-1-stable'
3334

3435
if version.gsub(/[^\d\.]/,'').to_f >= 6.0

0 commit comments

Comments
 (0)