Fix "uninitialized constant Gem" and other Travis errors (#1914)

* Fix RuboCop violation

* Update test harness for Bundler 1.16 compatibility

This commit fixes Travis failures due to the recent introduction of
Bundler 1.16.0. Both are related to the new style of binstubs that are
generated by 1.16.0.

First, add `bundler` to the list of binstubs that we explicitly generate
when creating the test Rails app. The `bin/bundle` binstub that ships as
part of `rails new` is in the pre-1.16 format, and conflicts with the
1.16 format binstubs that are generated for rake and rspec. Fix this by
replacing the default `bin/bundle` with a fresh one generated by
`bundle binstubs bundler --force`.

Second, the `Bundle.with_clean_env` wrapper seems to remove some
important information from the environment that causes binstubs to fail
with errors like `uninitialized constant Gem (NameError)`. Fix this by
using `Bundle.with_original_env` instead (which is what the Bundler
documentation recommends). Because Travis also sets its own
`BUNDLER_GEMFILE` variable, I had to also reset that one manually.

* Choose cuke tags based on correct RAILS_VERSION

* Travis needs doc gems in order to run bin/yard

* Add --no-rc flag for more reliable local testing

The rspec-rails acceptance tests use `rails new` to generate a sample
app for running tests. If a developer running the rspec-rails test suite
has a `.railsrc` file, this will affect the app that is generated,
causing specs to fail.

This commit fixes this by passing the `--no-rc` flag so that `rails new`
ignores the developer's local `.railsrc`.

Author: mattbrictson

.travis.yml

@@ -20,7 +20,7 @@ sudo: false
 # original `cache: bundler` is a better option.
 cache: bundler
 
-bundler_args: "--binstubs --without documentation --path ../bundle --retry=3 --jobs=3"
+bundler_args: "--binstubs --path ../bundle --retry=3 --jobs=3"
 
 before_install:
   - script/clone_all_rspec_repos

Rakefile

@@ -27,7 +27,7 @@ RSpec::Core::RakeTask.new(:spec) do |t|
 end
 
 Cucumber::Rake::Task.new(:cucumber) do |t|
-  version = ENV.fetch("RAILS_VERSION", "~> 4.2.0")
+  version = ENV.fetch("RAILS_VERSION", "~> 4.2.0")[/\d[\.-]\d/]
   tags = []
 
   if version.to_f >= 5.1
@@ -60,12 +60,12 @@ namespace :generate do
 
       # Rails 4 cannot use a `rails` binstub generated by Bundler
       sh "rm -f #{bindir}/rails"
-      sh "bundle exec rails new ./tmp/example_app --skip-javascript --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"
+      sh "bundle exec rails new ./tmp/example_app --no-rc --skip-javascript --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"
 
       in_example_app do
         sh "./travis_retry_bundle_install.sh 2>&1"
         # Rails 4 cannot use a `rails` binstub generated by Bundler
-        sh "bundle binstubs rspec-core rake --force"
+        sh "bundle binstubs bundler rspec-core rake --force"
         sh "bundle binstubs railties" unless File.exist?("bin/rails")
 
         application_file = File.read("config/application.rb")
@@ -93,7 +93,8 @@ def in_example_app(*command_opts)
     app_dir = opts.fetch(:app_dir, app_dir)
   end
   Dir.chdir(app_dir) do
-    Bundler.with_clean_env do
+    Bundler.with_original_env do
+      ENV["BUNDLE_GEMFILE"] = "Gemfile"
       sh *command_opts unless command_opts.empty?
       yield if block_given?
     end
@@ -182,12 +183,12 @@ namespace :no_active_record do
 
         # Rails 4 cannot use a `rails` binstub generated by Bundler
         sh "rm -f #{bindir}/rails"
-        sh "bundle exec rails new #{example_app_dir} --skip-active-record --skip-javascript --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"
+        sh "bundle exec rails new #{example_app_dir} --no-rc --skip-active-record --skip-javascript --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"
 
         in_example_app(:app_dir => example_app_dir) do
           sh "./travis_retry_bundle_install.sh 2>&1"
           # Rails 4 cannot use a `rails` binstub generated by Bundler
-          sh "bundle binstubs rspec-core rake --force"
+          sh "bundle binstubs bundler rspec-core rake --force"
           sh "bundle binstubs railties" unless File.exist?("bin/rails")
 
           application_file = File.read("config/application.rb")

lib/rspec/rails/example/system_example_group.rb

@@ -49,7 +49,7 @@ def app
             dependency on a webserver and `capybara`, please add capybara to
             your Gemfile and configure a webserver (e.g. `Capybara.server =
             :webrick`) before attempting to use system tests.
-          """.gsub(/\s+/,' ').strip
+          """.gsub(/\s+/, ' ').strip
         end
 
         original_after_teardown =