Disable cops in place for Ruby 1.8.7 support

Author: petergoldstein

.rubocop.yml

@@ -48,3 +48,14 @@ Metrics/ModuleLength:
   Exclude:
     - spec/**/*
 
+# Override the shared base defaults that are in place for 1.8.7 support
+
+Layout/DotPosition:
+  EnforcedStyle: leading
+
+Style/HashSyntax:
+  EnforcedStyle: ruby19
+
+Style/Lambda:
+  Enabled: true
+

Gemfile

@@ -4,11 +4,11 @@ gemspec
 
 eval_gemfile 'Gemfile-rspec-dependencies'
 
-gem 'yard', '~> 0.9.24', :require => false
+gem 'yard', '~> 0.9.24', require: false
 
 group :documentation do
   gem 'github-markup', '~> 3.0.3'
-  gem 'redcarpet', '~> 3.5.1', :platforms => [:ruby]
+  gem 'redcarpet', '~> 3.5.1', platforms: [:ruby]
   gem 'relish', '~> 0.7.1'
 end
 

Rakefile

@@ -94,7 +94,7 @@ end
 
 namespace :smoke do
   desc "create a new example app with generated specs and run them"
-  task :app => ["clobber:app", "generate:app", "generate:stuff", :smoke]
+  task app: ["clobber:app", "generate:app", "generate:stuff", :smoke]
 end
 
 desc 'clobber generated files'
@@ -132,12 +132,12 @@ namespace :no_active_record do
   desc "run a variety of specs against a non-ActiveRecord generated app"
   task :smoke do
     in_example_app "LOCATION='../../example_app_generator/run_specs.rb' bin/rake #{rails_template_command} --backtrace",
-                   :app_dir => example_app_dir
+                   app_dir: example_app_dir
   end
 
   namespace :smoke do
     desc "create a new example app without active record including generated specs and run them"
-    task :app => [
+    task app: [
       "no_active_record:clobber",
       "no_active_record:generate:app",
       "no_active_record:generate:stuff",
@@ -162,7 +162,7 @@ namespace :no_active_record do
            "--skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --skip-spring " \
            "--template=example_app_generator/generate_app.rb"
 
-        in_example_app(:app_dir => example_app_dir) do
+        in_example_app(app_dir: example_app_dir) do
           sh "./ci_retry_bundle_install.sh 2>&1"
           # Rails 4+ cannot use a `rails` binstub generated by Bundler
           sh "bundle binstubs bundler rspec-core rake --force"
@@ -183,14 +183,14 @@ namespace :no_active_record do
 
     desc "generate a bunch of stuff with generators"
     task :stuff do
-      in_example_app "bin/rake #{rails_template_command} LOCATION='../../example_app_generator/generate_stuff.rb'", :app_dir => example_app_dir
+      in_example_app "bin/rake #{rails_template_command} LOCATION='../../example_app_generator/generate_stuff.rb'", app_dir: example_app_dir
     end
   end
 end
 
-task :acceptance => ['smoke:app', 'no_active_record:smoke:app', :cucumber]
+task acceptance: ['smoke:app', 'no_active_record:smoke:app', :cucumber]
 
-task :default => [:spec, :acceptance]
+task default: [:spec, :acceptance]
 
 task :verify_private_key_present do
   private_key = File.expand_path('~/.gem/rspec-gem-private_key.pem')
@@ -199,4 +199,4 @@ task :verify_private_key_present do
   end
 end
 
-task :build => :verify_private_key_present
+task build: :verify_private_key_present

example_app_generator/generate_stuff.rb

@@ -129,11 +129,11 @@ def using_source_path(path)
 
 file "app/views/things/custom_action.html.erb",
      "This is a template for a custom action.",
-     :force => true
+     force: true
 
 file "app/views/errors/401.html.erb",
      "This is a template for rendering an error page",
-     :force => true
+     force: true
 
 # Use the absolute path so we can load it without active record too
 apply File.join(DEFAULT_SOURCE_PATH, 'generate_action_mailer_specs.rb')

example_app_generator/no_active_record/lib/rails/generators/in_memory/model/model_generator.rb

@@ -8,15 +8,15 @@ class ModelGenerator < ::Rspec::Generators::Base
 
       desc "Creates a Fake ActiveRecord acting model"
       argument :attributes,
-               :type => :array,
-               :default => [],
-               :banner => "field:type field:type"
+               type: :array,
+               default: [],
+               banner: "field:type field:type"
 
       check_class_collision
 
       class_option :parent,
-                   :type => :string,
-                   :desc => "The parent class for the generated model"
+                   type: :string,
+                   desc: "The parent class for the generated model"
 
       def create_model_file
         template "model.rb.erb",

example_app_generator/no_active_record/spec/verify_fixture_file_upload_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe 'Example App', :use_fixtures, :type => :model do
+RSpec.describe 'Example App', :use_fixtures, type: :model do
   it 'supports fixture file upload' do
     file = fixture_file_upload(__FILE__)
     expect(file.read).to match(/RSpec\.describe 'Example App'/im)

example_app_generator/no_active_record/spec/verify_no_fixture_setup_spec.rb

@@ -15,7 +15,7 @@ module TestFixtures
 
 require 'rails_helper'
 
-RSpec.describe 'Example App', :use_fixtures, :type => :model do
+RSpec.describe 'Example App', :use_fixtures, type: :model do
   it "does not set up fixtures" do
     expect(defined?(fixtures)).not_to be
   end

example_app_generator/spec/verify_custom_renderers_spec.rb

@@ -1,11 +1,11 @@
 require 'rails_helper'
 
-RSpec.describe "template rendering", :type => :controller do
+RSpec.describe "template rendering", type: :controller do
   context "without render_views" do
     context "with the standard renderers" do
       controller do
         def index
-          render :template => 'foo', :layout => false
+          render template: 'foo', layout: false
         end
       end
 
@@ -27,7 +27,7 @@ def index
         def index
           prepend_view_path('app/views/some_templates')
 
-          render :template => 'bar', :layout => false
+          render template: 'bar', layout: false
         end
       end
 
@@ -37,7 +37,7 @@ def index
         expect(response).to render_template(:bar)
       end
 
-      it "renders an empty string", :skip => Rails::VERSION::STRING.to_f >= 6.0 do
+      it "renders an empty string", skip: Rails::VERSION::STRING.to_f >= 6.0 do
         get :index
 
         expect(response.body).to eq("")
@@ -49,7 +49,7 @@ def index
         def index
           prepend_view_path(MyResolver.new)
 
-          render :template => 'baz', :layout => false
+          render template: 'baz', layout: false
         end
       end
 
@@ -73,7 +73,7 @@ def index
     context "with the standard renderers" do
       controller do
         def index
-          render :template => 'foo', :layout => false
+          render template: 'foo', layout: false
         end
       end
 
@@ -95,7 +95,7 @@ def index
         def index
           prepend_view_path('app/views/some_templates')
 
-          render :template => 'bar', :layout => false
+          render template: 'bar', layout: false
         end
       end
 
@@ -117,7 +117,7 @@ def index
         def index
           prepend_view_path(MyResolver.new)
 
-          render :template => 'baz', :layout => false
+          render template: 'baz', layout: false
         end
       end
 
@@ -151,9 +151,9 @@ def find_template(name, path)
         "",
         name,
         ->(template, _source = nil) { %("Dynamic template with path '#{template.virtual_path}'") },
-        :virtual_path => path,
-        :format => :html,
-        :locals => []
+        virtual_path: path,
+        format: :html,
+        locals: []
       )
     end
   end

example_app_generator/spec/verify_mailer_preview_path_spec.rb

@@ -16,7 +16,7 @@ def as_commandline(ops)
   end
 
   def capture_exec(*ops)
-    ops << { :err => [:child, :out] }
+    ops << { err: [:child, :out] }
     io = IO.popen(ops)
     # Necessary to ignore warnings from Rails code base
     out =  io.readlines
@@ -28,7 +28,7 @@ def capture_exec(*ops)
   end
 
   def have_no_preview
-    have_attributes(:io => be_blank, :exit_status => 0)
+    have_attributes(io: be_blank, exit_status: 0)
   end
 
   let(:exec_script) {

lib/generators/rspec/controller/controller_generator.rb

@@ -4,13 +4,13 @@ module Rspec
   module Generators
     # @private
     class ControllerGenerator < Base
-      argument :actions, :type => :array, :default => [], :banner => "action action"
+      argument :actions, type: :array, default: [], banner: "action action"
 
-      class_option :template_engine,  :desc => "Template engine to generate view files"
-      class_option :request_specs,    :type => :boolean, :default => true, :desc => "Generate request specs"
-      class_option :controller_specs, :type => :boolean, :default => false, :desc => "Generate controller specs"
-      class_option :view_specs,       :type => :boolean, :default => true, :desc => "Generate view specs"
-      class_option :routing_specs,    :type => :boolean, :default => false, :desc => "Generate routing specs"
+      class_option :template_engine,  desc: "Template engine to generate view files"
+      class_option :request_specs,    type: :boolean, default: true, desc: "Generate request specs"
+      class_option :controller_specs, type: :boolean, default: false, desc: "Generate controller specs"
+      class_option :view_specs,       type: :boolean, default: true, desc: "Generate view specs"
+      class_option :routing_specs,    type: :boolean, default: false, desc: "Generate routing specs"
 
       def generate_request_spec
         return unless options[:request_specs]

lib/generators/rspec/feature/feature_generator.rb

@@ -4,8 +4,8 @@ module Rspec
   module Generators
     # @private
     class FeatureGenerator < Base
-      class_option :feature_specs, :type => :boolean, :default => true,  :desc => "Generate feature specs"
-      class_option :singularize,   :type => :boolean, :default => false, :desc => "Singularize the generated feature"
+      class_option :feature_specs, type: :boolean, default: true,  desc: "Generate feature specs"
+      class_option :singularize,   type: :boolean, default: false, desc: "Singularize the generated feature"
 
       def generate_feature_spec
         return unless options[:feature_specs]

lib/generators/rspec/generator/generator_generator.rb

@@ -4,7 +4,7 @@ module Rspec
   module Generators
     # @private
     class GeneratorGenerator < Base
-      class_option :generator_specs, :type => :boolean, :default => true,  :desc => "Generate generator specs"
+      class_option :generator_specs, type: :boolean, default: true,  desc: "Generate generator specs"
 
       def generate_generator_spec
         return unless options[:generator_specs]

lib/generators/rspec/helper/helper_generator.rb

@@ -4,7 +4,7 @@ module Rspec
   module Generators
     # @private
     class HelperGenerator < Base
-      class_option :helper_specs, :type => :boolean, :default => true
+      class_option :helper_specs, type: :boolean, default: true
 
       def generate_helper_spec
         return unless options[:helper_specs]

lib/generators/rspec/install/install_generator.rb

@@ -32,8 +32,8 @@ def copy_rails_files
 
       def generate_rspec_init(tmpdir)
         initializer = ::RSpec::Core::ProjectInitializer.new(
-          :destination => tmpdir,
-          :report_stream => StringIO.new
+          destination: tmpdir,
+          report_stream: StringIO.new
         )
         initializer.run
 
@@ -47,7 +47,7 @@ def replace_generator_command(spec_helper_path)
         gsub_file spec_helper_path,
                   'rspec --init',
                   'rails generate rspec:install',
-                  :verbose => false
+                  verbose: false
       end
 
       def remove_warnings_configuration(spec_helper_path)
@@ -56,7 +56,7 @@ def remove_warnings_configuration(spec_helper_path)
         gsub_file spec_helper_path,
                   /#{empty_line}(#{comment_line})+\s+config\.warnings = true\n/,
                   '',
-                  :verbose => false
+                  verbose: false
       end
     end
   end

lib/generators/rspec/integration/integration_generator.rb

@@ -7,9 +7,9 @@ class IntegrationGenerator < Base
       # Add a deprecation for this class, before rspec-rails 4, to use the
       # `RequestGenerator` instead
       class_option :request_specs,
-                   :type => :boolean,
-                   :default => true,
-                   :desc => "Generate request specs"
+                   type: :boolean,
+                   default: true,
+                   desc: "Generate request specs"
 
       def generate_request_spec
         return unless options[:request_specs]

lib/generators/rspec/mailer/mailer_generator.rb

@@ -5,7 +5,7 @@ module Rspec
   module Generators
     # @private
     class MailerGenerator < Base
-      argument :actions, :type => :array, :default => [], :banner => "method method"
+      argument :actions, type: :array, default: [], banner: "method method"
 
       def generate_mailer_spec
         template "mailer_spec.rb", File.join('spec/mailers', class_path, "#{file_name}_spec.rb")

lib/generators/rspec/model/model_generator.rb

@@ -5,10 +5,10 @@ module Generators
     # @private
     class ModelGenerator < Base
       argument :attributes,
-               :type => :array,
-               :default => [],
-               :banner => "field:type field:type"
-      class_option :fixture, :type => :boolean
+               type: :array,
+               default: [],
+               banner: "field:type field:type"
+      class_option :fixture, type: :boolean
 
       def create_model_spec
         template_file = File.join(