Style/HashSyntax

Author: babrovka

Rakefile

@@ -122,7 +122,7 @@ end
 
 namespace :smoke do
   desc "create a new example app with generated specs and run them"
-  task :app => ["clobber:app", "generate:app", "generate:stuff", :smoke]
+  task app: ["clobber:app", "generate:app", "generate:stuff", :smoke]
 end
 
 desc 'clobber generated files'
@@ -160,12 +160,12 @@ namespace :no_active_record do
   desc "run a variety of specs against a non-ActiveRecord generated app"
   task :smoke do
     in_example_app "LOCATION='../../example_app_generator/run_specs.rb' bin/rake #{rails_template_command} --backtrace",
-                   :app_dir => example_app_dir
+                   app_dir: example_app_dir
   end
 
   namespace :smoke do
     desc "create a new example app without active record including generated specs and run them"
-    task :app => [
+    task app: [
       "no_active_record:clobber",
       "no_active_record:generate:app",
       "no_active_record:generate:stuff",
@@ -188,7 +188,7 @@ namespace :no_active_record do
         sh "rm -f #{bindir}/rails"
         sh "bundle exec rails new #{example_app_dir} --no-rc --skip-active-record --skip-javascript --skip-bootsnap --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"
 
-        in_example_app(:app_dir => example_app_dir) do
+        in_example_app(app_dir: example_app_dir) do
           sh "./travis_retry_bundle_install.sh 2>&1"
           # Rails 4+ cannot use a `rails` binstub generated by Bundler
           sh "bundle binstubs bundler rspec-core rake --force"
@@ -208,14 +208,14 @@ namespace :no_active_record do
 
     desc "generate a bunch of stuff with generators"
     task :stuff do
-      in_example_app "bin/rake #{rails_template_command} LOCATION='../../example_app_generator/generate_stuff.rb'", :app_dir => example_app_dir
+      in_example_app "bin/rake #{rails_template_command} LOCATION='../../example_app_generator/generate_stuff.rb'", app_dir: example_app_dir
     end
   end
 end
 
-task :acceptance => ['smoke:app', 'no_active_record:smoke:app', :cucumber]
+task acceptance: ['smoke:app', 'no_active_record:smoke:app', :cucumber]
 
-task :default => [:spec, :acceptance]
+task default: [:spec, :acceptance]
 
 task :verify_private_key_present do
   private_key = File.expand_path('~/.gem/rspec-gem-private_key.pem')
@@ -224,4 +224,4 @@ task :verify_private_key_present do
   end
 end
 
-task :build => :verify_private_key_present
+task build: :verify_private_key_present

example_app_generator/generate_stuff.rb

@@ -116,11 +116,11 @@ def using_source_path(path)
 
 file "app/views/things/custom_action.html.erb",
      "This is a template for a custom action.",
-     :force => true
+     force: true
 
 file "app/views/errors/401.html.erb",
      "This is a template for rendering an error page",
-     :force => true
+     force: true
 
 # Use the absolute path so we can load it without active record too
 apply File.join(DEFAULT_SOURCE_PATH, 'generate_action_mailer_specs.rb')

example_app_generator/no_active_record/lib/rails/generators/in_memory/model/model_generator.rb

@@ -8,15 +8,15 @@ class ModelGenerator < ::Rspec::Generators::Base
 
       desc "Creates a Fake ActiveRecord acting model"
       argument :attributes,
-               :type => :array,
-               :default => [],
-               :banner => "field:type field:type"
+               type: :array,
+               default: [],
+               banner: "field:type field:type"
 
       check_class_collision
 
       class_option :parent,
-                   :type => :string,
-                   :desc => "The parent class for the generated model"
+                   type: :string,
+                   desc: "The parent class for the generated model"
 
       def create_model_file
         template "model.rb.erb",

example_app_generator/spec/verify_custom_renderers_spec.rb

@@ -1,11 +1,11 @@
 require 'rails_helper'
 
-RSpec.describe "template rendering", :type => :controller do
+RSpec.describe "template rendering", type: :controller do
   context "without render_views" do
     context "with the standard renderers" do
       controller do
         def index
-          render :template => 'foo', :layout => false
+          render template: 'foo', layout: false
         end
       end
 
@@ -27,7 +27,7 @@ def index
         def index
           prepend_view_path('app/views/some_templates')
 
-          render :template => 'bar', :layout => false
+          render template: 'bar', layout: false
         end
       end
 
@@ -37,7 +37,7 @@ def index
         expect(response).to render_template(:bar)
       end
 
-      it "renders an empty string", :skip => Rails::VERSION::STRING.to_f >= 6.0 do
+      it "renders an empty string", skip: Rails::VERSION::STRING.to_f >= 6.0 do
         get :index
 
         expect(response.body).to eq("")
@@ -49,7 +49,7 @@ def index
         def index
           prepend_view_path(MyResolver.new)
 
-          render :template => 'baz', :layout => false
+          render template: 'baz', layout: false
         end
       end
 
@@ -73,7 +73,7 @@ def index
     context "with the standard renderers" do
       controller do
         def index
-          render :template => 'foo', :layout => false
+          render template: 'foo', layout: false
         end
       end
 
@@ -95,7 +95,7 @@ def index
         def index
           prepend_view_path('app/views/some_templates')
 
-          render :template => 'bar', :layout => false
+          render template: 'bar', layout: false
         end
       end
 
@@ -117,7 +117,7 @@ def index
         def index
           prepend_view_path(MyResolver.new)
 
-          render :template => 'baz', :layout => false
+          render template: 'baz', layout: false
         end
       end
 
@@ -151,9 +151,9 @@ def find_template(name, path)
         "",
         name,
         lambda { |template, _source = nil| %("Dynamic template with path '#{template.virtual_path}'") },
-        :virtual_path => path,
-        :format => :html,
-        :locals => []
+        virtual_path: path,
+        format: :html,
+        locals: []
       )
     end
   end

example_app_generator/spec/verify_mailer_preview_path_spec.rb

@@ -16,7 +16,7 @@ def as_commandline(ops)
   end
 
   def capture_exec(*ops)
-    ops << { :err => [:child, :out] }
+    ops << { err: [:child, :out] }
     io = IO.popen(ops)
     # Necessary to ignore warnings from Rails code base
     out =  io.readlines.
@@ -28,7 +28,7 @@ def capture_exec(*ops)
   end
 
   def have_no_preview
-    have_attributes(:io => be_blank, :exit_status => 0)
+    have_attributes(io: be_blank, exit_status: 0)
   end
 
   let(:exec_script) {

spec/generators/rspec/channel/channel_generator_spec.rb

@@ -2,7 +2,7 @@
 require "generators/rspec/channel/channel_generator"
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::ChannelGenerator, :type => :generator, :skip => !RSpec::Rails::FeatureCheck.has_action_cable_testing? do
+RSpec.describe Rspec::Generators::ChannelGenerator, type: :generator, skip: !RSpec::Rails::FeatureCheck.has_action_cable_testing? do
   setup_default_destination
 
   describe 'the generated files' do

spec/generators/rspec/controller/controller_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/controller/controller_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::ControllerGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::ControllerGenerator, type: :generator do
   setup_default_destination
 
   describe 'request specs' do

spec/generators/rspec/feature/feature_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/feature/feature_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::FeatureGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::FeatureGenerator, type: :generator do
   setup_default_destination
 
   describe 'feature specs' do

spec/generators/rspec/generator/generator_generator_spec.rb

@@ -1,7 +1,7 @@
 require 'generators/rspec/generator/generator_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::GeneratorGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::GeneratorGenerator, type: :generator do
   setup_default_destination
 
   describe "generator specs" do

spec/generators/rspec/helper/helper_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/helper/helper_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::HelperGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::HelperGenerator, type: :generator do
   setup_default_destination
 
   subject { file('spec/helpers/posts_helper_spec.rb') }

spec/generators/rspec/install/install_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/install/install_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::InstallGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::InstallGenerator, type: :generator do
   def use_active_record_migration
     match(/ActiveRecord::Migration\./m)
   end

spec/generators/rspec/integration/integration_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/integration/integration_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::IntegrationGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::IntegrationGenerator, type: :generator do
   setup_default_destination
   it_behaves_like "a request spec generator"
 end

spec/generators/rspec/job/job_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/job/job_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::JobGenerator, :type => :generator, :skip => !RSpec::Rails::FeatureCheck.has_active_job? do
+RSpec.describe Rspec::Generators::JobGenerator, type: :generator, skip: !RSpec::Rails::FeatureCheck.has_active_job? do
   setup_default_destination
 
   describe 'the generated files' do

spec/generators/rspec/mailbox/mailbox_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/mailbox/mailbox_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::MailboxGenerator, :type => :generator, :skip => !RSpec::Rails::FeatureCheck.has_action_mailbox? do
+RSpec.describe Rspec::Generators::MailboxGenerator, type: :generator, skip: !RSpec::Rails::FeatureCheck.has_action_mailbox? do
   setup_default_destination
 
   describe 'the generated files' do

spec/generators/rspec/mailer/mailer_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/mailer/mailer_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::MailerGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::MailerGenerator, type: :generator do
   setup_default_destination
 
   describe 'mailer spec' do
@@ -44,7 +44,7 @@
     end
   end
 
-  describe 'a preview is generated for each action', :skip => !RSpec::Rails::FeatureCheck.has_action_mailer_preview? do
+  describe 'a preview is generated for each action', skip: !RSpec::Rails::FeatureCheck.has_action_mailer_preview? do
     subject { file('spec/mailers/previews/posts_preview.rb') }
     before do
       run_generator %w[posts index show]

spec/generators/rspec/model/model_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/model/model_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::ModelGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::ModelGenerator, type: :generator do
   setup_default_destination
 
   it 'runs both the model and fixture tasks' do

spec/generators/rspec/request/request_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/request/request_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::RequestGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::RequestGenerator, type: :generator do
   setup_default_destination
   it_behaves_like "a request spec generator"
 end

spec/generators/rspec/system/system_generator_spec.rb

@@ -3,7 +3,7 @@
   require 'generators/rspec/system/system_generator'
   require 'support/generators'
 
-  RSpec.describe Rspec::Generators::SystemGenerator, :type => :generator do
+  RSpec.describe Rspec::Generators::SystemGenerator, type: :generator do
     setup_default_destination
 
     describe "system specs" do

spec/generators/rspec/view/view_generator_spec.rb

@@ -2,7 +2,7 @@
 require 'generators/rspec/view/view_generator'
 require 'support/generators'
 
-RSpec.describe Rspec::Generators::ViewGenerator, :type => :generator do
+RSpec.describe Rspec::Generators::ViewGenerator, type: :generator do
   setup_default_destination
 
   describe 'with default template engine' do

spec/rspec/rails/example/controller_example_group_spec.rb

@@ -23,7 +23,7 @@ def group_for(klass)
       it "uses the controller as the subject" do
         controller = double('controller')
         example = group.new
-        allow(example).to receive_messages(:controller => controller)
+        allow(example).to receive_messages(controller: controller)
         expect(example.subject).to eq(controller)
       end
 
@@ -73,7 +73,7 @@ def my_helper
         end
 
         allow(controller).to receive(:foos_url).and_return('http://test.host/foos')
-        allow(example).to receive_messages(:controller => controller)
+        allow(example).to receive_messages(controller: controller)
         example.instance_variable_set(:@orig_routes, routes)
       end
 

spec/rspec/rails/example/feature_example_group_spec.rb

@@ -6,7 +6,7 @@ module RSpec::Rails
     it "includes Rails route helpers" do
       with_isolated_stderr do
         Rails.application.routes.draw do
-          get "/foo", :as => :foo, :to => "foo#bar"
+          get "/foo", as: :foo, to: "foo#bar"
         end
       end