Merge pull request #2678 from r7kamura/rails-root-glob

JonRowe · web-flow · commit fd5053df3888 · 2023-05-18T09:49:34.000+01:00
Prefer `Pathname#glob` to `Dir.[]` at spec/rails_helper.rb template
diff --git a/lib/generators/rspec/install/templates/spec/rails_helper.rb b/lib/generators/rspec/install/templates/spec/rails_helper.rb
@@ -20,7 +20,7 @@
 # directory. Alternatively, in the individual `*_spec.rb` files, manually
 # require only the support files necessary.
 #
-# Dir[Rails.root.join('spec/support/**/*.rb')].sort.each { |f| require f }
+# Rails.root.glob('spec/support/**/*.rb').sort.each { |f| require f }
 
 <% if RSpec::Rails::FeatureCheck.has_active_record_migration? -%>
 # Checks for pending migrations and applies them before tests are run.

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	# directory. Alternatively, in the individual `*_spec.rb` files, manually
`21`	`21`	`# require only the support files necessary.`
`22`	`22`	`#`
`23`		`-# Dir[Rails.root.join('spec/support/*/.rb')].sort.each { \|f\| require f }`
	`23`	`+# Rails.root.glob('spec/support/*/.rb').sort.each { \|f\| require f }`
`24`	`24`
`25`	`25`	`<% if RSpec::Rails::FeatureCheck.has_active_record_migration? -%>`
`26`	`26`	`# Checks for pending migrations and applies them before tests are run.`