Add tests for have_enqueued_mail matcher at_least and at_most modifiers

Author: Joel Lubrano

lib/rspec/rails/matchers/have_enqueued_mail.rb

@@ -50,23 +50,32 @@ def with(*args)
           end
         end
 
+        def times
+          self
+        end
+
         def failure_message
-          base_message.tap do |msg|
-            msg << " #{expected_count_message}"
-            msg << " with #{@args}" if @args.any?
-            msg << " but enqueued #{@job_matcher.matching_jobs.size}"
+          "expected to enqueue #{base_message}".tap do |msg|
             msg << "\n#{unmatching_mail_jobs_message}" if unmatching_mail_jobs.any?
           end
         end
 
+        def failure_message_when_negated
+          "expected not to enqueue #{base_message}"
+        end
+
         def supports_block_expectations?
           true
         end
 
         private
 
         def base_message
-          "expected to enqueue #{@mailer_class.name}.#{@method_name}"
+          "#{@mailer_class.name}.#{@method_name}".tap do |msg|
+            msg << " #{expected_count_message}"
+            msg << " with #{@args}" if @args.any?
+            msg << ", but enqueued #{@job_matcher.matching_jobs.size}"
+          end
         end
 
         def expected_count_message

spec/rspec/rails/matchers/have_enqueued_mail_spec.rb

@@ -70,6 +70,28 @@ def email_with_optional_args(required_arg, optional_arg = nil); end
       }.to raise_error(/expected to enqueue TestMailer.test_email exactly 1 time/)
     end
 
+    it "matches based on mailer class and method name" do
+      expect {
+        TestMailer.test_email.deliver_later
+        TestMailer.email_with_args(1, 2).deliver_later
+      }.to have_enqueued_mail(TestMailer, :test_email).once
+    end
+
+    it "passes with multiple emails" do
+      expect {
+        TestMailer.test_email.deliver_later
+        TestMailer.email_with_args(1, 2).deliver_later
+      }.to have_enqueued_mail(TestMailer, :test_email).and have_enqueued_mail(TestMailer, :email_with_args)
+    end
+
+    it 'fails when negated and mail is enqueued' do
+      expect {
+        expect {
+          TestMailer.test_email.deliver_later
+        }.not_to have_enqueued_mail(TestMailer, :test_email)
+      }.to raise_error(/expected not to enqueue TestMailer.test_email exactly 1 time, but enqueued 1/)
+    end
+
     it "passes with :once count" do
       expect {
         TestMailer.test_email.deliver_later
@@ -91,18 +113,32 @@ def email_with_optional_args(required_arg, optional_arg = nil); end
       }.to have_enqueued_mail(TestMailer, :test_email).thrice
     end
 
-    it "matches based on mailer class and method name" do
+    it "passes with at_least when enqueued emails are over the limit" do
       expect {
         TestMailer.test_email.deliver_later
-        TestMailer.email_with_args(1, 2).deliver_later
-      }.to have_enqueued_mail(TestMailer, :test_email).once
+        TestMailer.test_email.deliver_later
+      }.to have_enqueued_mail(TestMailer, :test_email).at_least(:once)
     end
 
-    it "passes with multiple emails" do
+    it "passes with at_most when enqueued emails are under the limit" do
       expect {
         TestMailer.test_email.deliver_later
-        TestMailer.email_with_args(1, 2).deliver_later
-      }.to have_enqueued_mail(TestMailer, :test_email).and have_enqueued_mail(TestMailer, :email_with_args)
+      }.to have_enqueued_mail(TestMailer, :test_email).at_most(:twice)
+    end
+
+    it "generates a failure message with at least hint" do
+      expect {
+        expect { }.to have_enqueued_mail(TestMailer, :test_email).at_least(:once)
+      }.to raise_error(/expected to enqueue TestMailer.test_email at least 1 time, but enqueued 0/)
+    end
+
+    it "generates a failure message with at most hint" do
+      expect {
+        expect {
+          TestMailer.test_email.deliver_later
+          TestMailer.test_email.deliver_later
+        }.to have_enqueued_mail(TestMailer, :test_email).at_most(:once)
+      }.to raise_error(/expected to enqueue TestMailer.test_email at most 1 time, but enqueued 2/)
     end
 
     it "passes for mailer methods that accept arguments when the provided argument matcher is not used" do
@@ -144,11 +180,11 @@ def email_with_optional_args(required_arg, optional_arg = nil); end
     it "generates a failure message with arguments" do
       expect {
         expect { }.to have_enqueued_email(TestMailer, :email_with_args).with(1, 2)
-      }.to raise_error(/expected to enqueue TestMailer.email_with_args exactly 1 time with \[1, 2\] but enqueued 0/)
+      }.to raise_error(/expected to enqueue TestMailer.email_with_args exactly 1 time with \[1, 2\], but enqueued 0/)
     end
 
     it "generates a failure message with unmatching enqueued mail jobs" do
-      message = "expected to enqueue TestMailer.email_with_args exactly 1 time with [1, 2] but enqueued 0" + \
+      message = "expected to enqueue TestMailer.email_with_args exactly 1 time with [1, 2], but enqueued 0" + \
                 "\nQueued deliveries:" + \
                 "\n  TestMailer.test_email" + \
                 "\n  TestMailer.email_with_args with [3, 4]"