-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix generator spec generator #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2b69597
Properly Rename Generator Directory
joel 439feed
Properly Rename Generator
joel f765be6
Fix Generate Generator Spec
joel 2ae4d21
Do Not Generate Spec By Default
joel 3553463
Add feature spec when generating generator
benoittgt 4a8e2f5
Their is no need to clean files generated by rails command
benoittgt 9dc2924
Rephrase few sentences of feature spec
benoittgt 41a38fa
Rails generate generator command create spec by default
benoittgt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
Feature: Generator spec | ||
|
||
RSpec spec are normally generated alongside other application components. | ||
For instance, `rails generate model` will also generate an RSpec spec file | ||
for the model but you can also use your own generator. See | ||
benoittgt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
[customizing your workflow](https://guides.rubyonrails.org/generators.html#customizing-your-workflow) | ||
benoittgt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@remove-generator-files | ||
Scenario: Use custom generator without '--generator-specs' arg | ||
When I run `bundle exec rails generate generator my_generator` | ||
Then the features should pass | ||
Then the output should contain: | ||
""" | ||
create lib/generators/my_generator | ||
create lib/generators/my_generator/my_generator_generator.rb | ||
create lib/generators/my_generator/USAGE | ||
create lib/generators/my_generator/templates | ||
invoke rspec | ||
""" | ||
|
||
@remove-generator-files | ||
Scenario: Use custom generator with '--generator-specs' arg | ||
When I run `bundle exec rails generate generator my_generator --generator-specs` | ||
Then the features should pass | ||
Then the output should contain: | ||
""" | ||
create lib/generators/my_generator | ||
create lib/generators/my_generator/my_generator_generator.rb | ||
create lib/generators/my_generator/USAGE | ||
create lib/generators/my_generator/templates | ||
invoke rspec | ||
create spec/generator/my_generators_generator_spec.rb | ||
""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
Before('@remove-generator-files') do | ||
command = <<-COMMAND | ||
rm -f \ | ||
tmp/example_app/lib/generators/my_generator \ | ||
tmp/example_app/lib/generators/my_generator/my_generator_generator.rb \ | ||
tmp/example_app/lib/generators/my_generator/USAGE \ | ||
tmp/example_app/lib/generators/my_generator/templates \ | ||
tmp/example_app/spec/generator/my_generator_spec.rb | ||
COMMAND | ||
system(command) | ||
end | ||
benoittgt marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
...ec/generators/generator_generator_spec.rb → ...pec/generator/generator_generator_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.