Remove Appveyor

Author: pirj

appveyor.yml

@@ -35,10 +35,6 @@
   c.filter_run_when_matching :focus
 
   c.example_status_persistence_file_path = "./spec/examples.txt"
-
-  c.define_derived_metadata :failing_on_appveyor do |meta|
-    meta[:pending] ||= "This spec fails on AppVeyor and needs someone to fix it."
-  end if ENV['APPVEYOR']
 end
 
 module RSpec

lib/rspec/support/spec.rb

@@ -155,7 +155,7 @@ def differ_ivars
             expect(diff).to be_diffed_as(expected_diff)
           end
 
-          it 'uses the default external encoding when the two strings have incompatible encodings', :failing_on_appveyor do
+          it 'uses the default external encoding when the two strings have incompatible encodings' do
             expected = "Tu avec carte {count} item has\n"
             actual   = "Tu avec carté {count} itém has\n".encode('UTF-16LE')
             expected_diff = "\n@@ #{one_line_header} @@\n-Tu avec carte {count} item has\n+Tu avec carté {count} itém has\n"
@@ -312,7 +312,7 @@ def inspect; "<BrokenObject>"; end
           end
         end
 
-        it 'outputs unified diff message of two hashes with differing encoding', :failing_on_appveyor do
+        it 'outputs unified diff message of two hashes with differing encoding' do
           expected_diff = dedent(<<-"EOD")
             |
             |@@ #{one_line_header} @@
@@ -325,7 +325,7 @@ def inspect; "<BrokenObject>"; end
           expect(diff).to be_diffed_as(expected_diff)
         end
 
-        it 'outputs unified diff message of two hashes with encoding different to key encoding', :failing_on_appveyor do
+        it 'outputs unified diff message of two hashes with encoding different to key encoding' do
           expected_diff = dedent(<<-"EOD")
             |
             |@@ #{one_line_header} @@

spec/rspec/support/differ_spec.rb

@@ -28,9 +28,8 @@ def directory_exists?(dirname)
       context "when a file already exists" do
         before { File.open("tmp", "w") }
 
-        it "raises, as it can't make the directory", :failing_on_appveyor,
-           :pending => false,
-           :skip => (ENV['APPVEYOR'] ? "Failing on AppVeyor but :pending isn't working for some reason" : false) do
+        it "raises, as it can't make the directory" do
+          pending "Fails on Windows for some reason yet to be discovered" if RSpec::Support::OS.windows?
           expect {
             mkdir_p.call(dirname)
           }.to raise_error(Errno::EEXIST)

spec/rspec/support/directory_maker_spec.rb

@@ -31,7 +31,7 @@
     # On 2.2, there's a weird issue where stderr sometimes responds to `birthtime` and sometimes doesn't...
     stderr_methods -= [:birthtime] if RUBY_VERSION =~ /^2\.2/
 
-    # No idea why, but on our AppVeyor windows builds it doesn't respond to these...
+    # No idea why, but on our windows builds it doesn't respond to these...
     stderr_methods -= [:close_on_exec?, :close_on_exec=] if RSpec::Support::OS.windows?
 
     expect(splitter).to respond_to(*stderr_methods)