Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit 1f2219c

Browse files
committed
Restore original JRuby ripper suppression
1 parent eda9918 commit 1f2219c

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

lib/rspec/support/ruby_features.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ def supports_taint?
113113
# or cannot parse source including `:if`.
114114
# Ripper on JRuby 9.x.x.x < 9.1.17.0 can't handle keyword arguments
115115
# Neither can JRuby 9.2, e.g. < 9.2.1.0
116-
ripper_requirements.push(!Ruby.jruby_version.between?('9.0.0.0.rc1', '9.1.16.0'))
117-
ripper_requirements.push(!Ruby.jruby_version.between?('9.1.999.0', '9.1.999.0'))
116+
ripper_requirements.push(!Ruby.jruby_version.between?('9.0.0.0.rc1', '9.2.0.0'))
118117
end
119118

120119
if ripper_requirements.all?

spec/rspec/support/ruby_features_spec.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,9 @@ def ripper_can_parse_source_referencing_keyword_arguments?
165165
end
166166

167167
it 'returns whether Ripper is correctly implemented in the current environment' do
168+
if RSpec::Support::Ruby.jruby? && RSpec::Support::Ruby.jruby_version < '9.2.1.0'
169+
pending "Ripper is not supported on JRuby 9.1.17.0 despite this tests claims"
170+
end
168171
expect(RubyFeatures.ripper_supported?).to eq(ripper_is_implemented? && ripper_works_correctly?)
169172
end
170173

0 commit comments

Comments
 (0)