Merge pull request #281 from rspec/ignore_bundler_warnings

Ignore bundler warnings on windows

Author: JonRowe

lib/rspec/support/spec/library_wide_checks.rb

@@ -68,9 +68,7 @@ def load_all_files(files, preamble, postamble=nil)
       run_ruby_with_current_load_path(command, *options)
     end
 
-    # Ignore bundler warning.
-    stderr = stderr.split("\n").reject { |l| l =~ %r{bundler/source/rubygems} }.join("\n")
-    [stdout, stderr, status.exitstatus]
+    [stdout, strip_known_warnings(stderr), status.exitstatus]
   end
 
   define_method :load_all_lib_files do

lib/rspec/support/spec/shell_out.rb

@@ -53,6 +53,17 @@ def run_ruby_with_current_load_path(ruby_command, *flags)
         end
       end
 
+      def strip_known_warnings(input)
+        input.split("\n").reject do |l|
+          # Ignore bundler warning.
+          l =~ %r{bundler/source/rubygems} ||
+          # Ignore bundler + rubygems warning.
+          l =~ %r{site_ruby/\d\.\d\.\d/rubygems} ||
+          # This is required for windows for some reason
+          l =~ %r{lib/bundler/rubygems}
+        end.join("\n")
+      end
+
     private
 
       if Ruby.jruby?

spec/rspec/support/spec/shell_out_spec.rb

@@ -33,15 +33,15 @@
   it 'passes along the provided ruby flags' do
     out, err, status = run_ruby_with_current_load_path('puts "version"', '-v')
     expect(out).to include('version', RUBY_DESCRIPTION)
-    expect(err).to eq('')
+    expect(strip_known_warnings err).to eq('')
     expect(status.exitstatus).to eq(0)
   end
 
   it 'filters out the annoying output issued by `ruby -w` when the GC ENV vars are set' do
     with_env 'RUBY_GC_HEAP_FREE_SLOTS' => '10001', 'RUBY_GC_MALLOC_LIMIT' => '16777217', 'RUBY_FREE_MIN' => '10001' do
       out, err, status = run_ruby_with_current_load_path('', '-w')
       expect(out).to eq('')
-      expect(err).to eq('')
+      expect(strip_known_warnings err).to eq('')
       expect(status.exitstatus).to eq(0)
     end
   end