Merge pull request #68 from rspec/fix-with-isolated-stderr

Fix `with_isolated_stderr` so it does not leak.

Author: myronmarston

lib/rspec/support/spec/with_isolated_stderr.rb

@@ -6,6 +6,7 @@ def with_isolated_stderr
         original = $stderr
         $stderr = StringIO.new
         yield
+      ensure
         $stderr = original
       end
 

spec/rspec/support/spec/with_isolated_std_err_spec.rb

@@ -8,4 +8,14 @@
       $stderr.puts "Imma gonna warn you"
     end
   end
+
+  it 'resets $stderr to its original value even if an error is raised' do
+    orig_stderr = $stderr
+
+    expect {
+      with_isolated_stderr { raise "boom" }
+    }.to raise_error("boom")
+
+    expect($stderr).to be(orig_stderr)
+  end
 end