Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit 935d0cb

Browse files
committed
Fix simplecov source file filter
simplecov 0.20.0 does filtering with abosulute file paths. We were not excluding `bundle` directory. Before (https://github.com/rspec/rspec-support/runs/1627962469) ``` Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-support/coverage. 956 / 1444 LOC (66.2%) covered. Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-expectations/coverage. 3116 / 3596 LOC (86.65%) covered. ``` After (https://github.com/rspec/rspec-support/pull/480/checks?check_run_id=1628102829) ``` Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-support/coverage. 519 / 544 LOC (95.4%) covered. Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-expectations/coverage. 2767 / 2797 LOC (98.93%) covered. ``` Debug output, excerpt from `coverage/index.html` (https://github.com/rspec/rspec-expectations/pull/1273/checks?check_run_id=1628049675): ``` <td class="strong t-file__name">...bundle/ruby/2.7.0/gems/diff-lcs-1.4.4/lib/diff/lcs.rb">bundle/ruby/2.7.0/gems/diff-lcs-1.4.4/lib/diff/lcs.rb ...</td> <td class="red strong cell--number t-file__coverage">33.08 %</td> ```
1 parent 627e816 commit 935d0cb

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/rspec/support/spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ def self.setup_simplecov(&block)
6464

6565
def self.start_simplecov(&block)
6666
SimpleCov.start do
67-
add_filter "./bundle/"
68-
add_filter "./tmp/"
67+
add_filter "bundle/"
68+
add_filter "tmp/"
6969
add_filter do |source_file|
7070
# Filter out `spec` directory except when it is under `lib`
7171
# (as is the case in rspec-support)

0 commit comments

Comments
 (0)