Get rid of evals

Author: pirj

spec/rspec/support/method_signature_verifier_spec.rb

@@ -205,9 +205,7 @@ def arity_optional(x, y, z = 1); end
         end
 
         describe 'a method with optional keyword arguments' do
-          eval <<-RUBY
-            def arity_kw(x, y:1, z:2); end
-          RUBY
+          def arity_kw(x, y:1, z:2); end
 
           let(:test_method) { method(:arity_kw) }
 
@@ -298,9 +296,7 @@ def arity_kw(x, y:1, z:2); end
         end
 
         describe 'a method with optional argument and keyword arguments' do
-          eval <<-RUBY
-            def arity_kw(x, y = {}, z:2); end
-          RUBY
+          def arity_kw(x, y = {}, z:2); end
 
           let(:test_method) { method(:arity_kw) }
 
@@ -392,9 +388,7 @@ def arity_kw(x, y = {}, z:2); end
         end
 
         describe 'a method with required keyword arguments' do
-          eval <<-RUBY
-            def arity_required_kw(x, y:, z:, a: 'default'); end
-          RUBY
+          def arity_required_kw(x, y:, z:, a: 'default'); end
 
           let(:test_method) { method(:arity_required_kw) }
 
@@ -492,9 +486,7 @@ def arity_required_kw(x, y:, z:, a: 'default'); end
         end
 
         describe 'a method with required keyword arguments and a splat' do
-          eval <<-RUBY
-            def arity_required_kw_splat(w, *x, y:, z:, a: 'default'); end
-          RUBY
+          def arity_required_kw_splat(w, *x, y:, z:, a: 'default'); end
 
           let(:test_method) { method(:arity_required_kw_splat) }
 
@@ -585,9 +577,7 @@ def arity_required_kw_splat(w, *x, y:, z:, a: 'default'); end
         end
 
         describe 'a method with required keyword arguments and a keyword arg splat' do
-          eval <<-RUBY
-            def arity_kw_arg_splat(x:, **rest); end
-          RUBY
+          def arity_kw_arg_splat(x:, **rest); end
 
           let(:test_method) { method(:arity_kw_arg_splat) }
 
@@ -649,9 +639,7 @@ def arity_kw_arg_splat(x:, **rest); end
         end
 
         describe 'a method with a required arg and a keyword arg splat' do
-          eval <<-RUBY
-            def arity_kw_arg_splat(x, **rest); end
-          RUBY
+          def arity_kw_arg_splat(x, **rest); end
 
           let(:test_method) { method(:arity_kw_arg_splat) }
 
@@ -924,9 +912,7 @@ def arity_block(_, &block); end
         it_behaves_like 'a method verifier'
 
         describe 'providing a matcher for optional keyword arguments' do
-          eval <<-RUBY
-            def arity_kw(x, y:1); end
-          RUBY
+          def arity_kw(x, y:1); end
 
           let(:test_method) { method(:arity_kw) }
 
@@ -936,9 +922,7 @@ def arity_kw(x, y:1); end
         end
 
         describe 'providing a matcher for required keyword arguments' do
-          eval <<-RUBY
-            def arity_kw_required(x, y:); end
-          RUBY
+          def arity_kw_required(x, y:); end
 
           let(:test_method) { method(:arity_kw_required) }
 
@@ -952,9 +936,7 @@ def arity_kw_required(x, y:); end
         it_behaves_like 'a method verifier'
 
         describe 'for optional keyword arguments' do
-          eval <<-RUBY
-            def arity_kw(x, y:1, z:2); end
-          RUBY
+          def arity_kw(x, y:1, z:2); end
 
           let(:test_method) { method(:arity_kw) }
 
@@ -968,9 +950,7 @@ def arity_kw(x, y:1, z:2); end
         end
 
         describe 'providing a matcher for required keyword arguments' do
-          eval <<-RUBY
-            def arity_kw_required(x, y:); end
-          RUBY
+          def arity_kw_required(x, y:); end
 
           let(:test_method) { method(:arity_kw_required) }
 

spec/rspec/support/with_keywords_when_needed_spec.rb

@@ -27,21 +27,15 @@ def run(klass, *args, &block)
       end
 
       it "will run a block with optional keyword arguments when none are provided" do
-        binding.eval(<<-CODE, __FILE__, __LINE__)
         run(klass, 42) { |arg, val: nil| check_argument(arg) }
-        CODE
       end
 
       it "will run a block with optional keyword arguments when they are provided" do
-        binding.eval(<<-CODE, __FILE__, __LINE__)
         run(klass, val: 42) { |val: nil| check_argument(val) }
-        CODE
       end
 
       it "will run a block with required keyword arguments" do
-        binding.eval(<<-CODE, __FILE__, __LINE__)
         run(klass, val: 42) { |val:| check_argument(val) }
-        CODE
       end
     end
   end