Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit e183117

Browse files
committed
Update ripper_supported? for truffleruby and ripper specs to only run when supported
1 parent 596198a commit e183117

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

lib/rspec/support/ruby_features.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@ def non_mri?
4747
def mri?
4848
!defined?(RUBY_ENGINE) || RUBY_ENGINE == 'ruby'
4949
end
50+
51+
def truffleruby?
52+
defined?(RUBY_ENGINE) && RUBY_ENGINE == 'truffleruby'
53+
end
5054
end
5155

5256
# @api private
@@ -101,7 +105,7 @@ def supports_taint?
101105
end
102106
ripper_requirements = [ComparableVersion.new(RUBY_VERSION) >= '1.9.2']
103107

104-
ripper_requirements.push(false) if Ruby.rbx?
108+
ripper_requirements.push(false) if Ruby.rbx? || Ruby.truffleruby?
105109

106110
if Ruby.jruby?
107111
ripper_requirements.push(Ruby.jruby_version >= '1.7.5')

spec/rspec/support/ruby_features_spec.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@ def ripper_works_correctly?
123123
ripper_can_parse_source_including_keywordish_symbol?
124124
end
125125

126+
def self.ripper_supported?
127+
RubyFeatures.ripper_supported?
128+
end
129+
126130
# https://github.com/jruby/jruby/issues/3386
127131
def ripper_reports_correct_line_number?
128132
in_sub_process_if_possible do
@@ -144,7 +148,7 @@ def ripper_can_parse_source_including_keywordish_symbol?
144148
end
145149
end
146150

147-
it 'returns whether Ripper is correctly implemented in the current environment' do
151+
it 'returns whether Ripper is correctly implemented in the current environment', :if => ripper_supported? do
148152
expect(RubyFeatures.ripper_supported?).to eq(ripper_is_implemented? && ripper_works_correctly?)
149153
end
150154

0 commit comments

Comments
 (0)