Drop Ruby < 2.3

.rubocop.yml

@@ -19,15 +19,18 @@ Style/EvalWithLocation:
     # eval is only used here to check syntax
     - 'lib/rspec/support/ruby_features.rb'
 
-Lint/AssignmentInCondition:
-  Exclude:
-    # The pattern makes sense here
-    - 'lib/rspec/support/mutex.rb'
-
 # Over time we'd like to get this down, but this is what we're at now.
 Metrics/AbcSize:
   Max: 22
 
 # Over time we'd like to get this down, but this is what we're at now.
 Metrics/PerceivedComplexity:
   Max: 9
+
+# TODO: turn on cops below sometimes later
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Performance/UnfreezeString:
+  Enabled: false

.rubocop_rspec_base.yml

@@ -39,28 +39,12 @@ CyclomaticComplexity:
 Documentation:
   Enabled: false
 
-# We still support 1.8.7 which requires trailing dots
-DotPosition:
-  EnforcedStyle: trailing
-
 DoubleNegation:
   Enabled: false
 
-# each_with_object is unavailable on 1.8.7 so we have to disable this one.
-EachWithObject:
-  Enabled: false
-
 FormatString:
   EnforcedStyle: percent
 
-# As long as we support ruby 1.8.7 we have to use hash rockets.
-HashSyntax:
-  EnforcedStyle: hash_rockets
-
-# We can't use the new lambda syntax, since we still support 1.8.7.
-Lambda:
-  Enabled: false
-
 # Over time we'd like to get this down, but this is what we're at now.
 LineLength:
   Max: 100
@@ -90,11 +74,6 @@ PercentLiteralDelimiters:
 PredicateName:
   Enabled: false
 
-# On 1.8 `proc` is `lambda`, so we use `Proc.new` to ensure we get real procs on all supported versions.
-# http://batsov.com/articles/2014/02/04/the-elements-of-style-in-ruby-number-12-proc-vs-proc-dot-new/
-Proc:
-  Enabled: false
-
 # Exceptions should be rescued with `Support::AllExceptionsExceptOnesWeMustNotRescue`
 RescueException:
   Enabled: true

.travis.yml

@@ -15,33 +15,24 @@ before_install:
 bundler_args: "--binstubs --standalone --without documentation --path ../bundle"
 script: "script/run_build"
 rvm:
-  - 1.8.7
-  - 1.9.2
-  - 1.9.3
-  - 2.0.0
-  - 2.1
-  - 2.2.10
   - 2.3.8
   - 2.4.10
   - 2.5.8
   - 2.6.6
-  - 2.7.1
+  - 2.7.2
   - ruby-3.0.0-preview1
   - ruby-head
   - ree
   - rbx-3
-  - jruby-9.1.7.0 # pin JRuby to this until travis/rvm can install later versions
+  - jruby-9.2
   - jruby-head
-  - jruby-1.7
 env:
   - JRUBY_OPTS='--dev'
 matrix:
   include:
-    - rvm: jruby-1.7
-      env: JRUBY_OPTS='--dev --1.8'
-    - rvm: 2.7.1
+    - rvm: 2.7.2
       env: DIFF_LCS_VERSION="~> 1.3.0"
-    - rvm: 2.7.1
+    - rvm: 2.7.2
       env: DIFF_LCS_VERSION="1.4.3"
   allow_failures:
     - rvm: jruby-head

Gemfile

@@ -13,49 +13,21 @@ branch = File.read(File.expand_path("../maintenance-branch", __FILE__)).chomp
   end
 end
 
-if RUBY_VERSION < '1.9.3'
-  gem 'rake', '< 11.0.0' # rake 11 requires Ruby 1.9.3 or later
-elsif RUBY_VERSION < '2.0.0'
-  gem 'rake', '< 12.0.0' # rake 12 requires Ruby 2.0.0 or later
-else
-  gem 'rake', '>= 12.3.3'
-end
-
 if ENV['DIFF_LCS_VERSION']
   gem 'diff-lcs', ENV['DIFF_LCS_VERSION']
 else
   gem 'diff-lcs', '~> 1.4', '>= 1.4.3'
 end
 
-if RUBY_VERSION < '2.3.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/)
-  gem "childprocess", "< 1.0.0"
-elsif RUBY_VERSION < '2.3.0'
-  gem "childprocess", "< 3.0.0"
-else
 gem "childprocess", ">= 3.0.0"
-end
+gem 'ffi', '~> 1.11.0'
 
 ### dep for ci/coverage
 gem 'simplecov', '~> 0.8'
 
-if RUBY_VERSION < '2.0.0' || RUBY_ENGINE == 'java'
-  gem 'json', '< 2.0.0' # is a dependency of simplecov
-else
-  gem 'json', '> 2.3.0'
-end
-
-if RUBY_VERSION < '2.2.0' && !!(RbConfig::CONFIG['host_os'] =~ /cygwin|mswin|mingw|bccwin|wince|emx/)
-  gem 'ffi', '< 1.10'
-elsif RUBY_VERSION < '2.0'
-  # ffi dropped Ruby 1.8 support in 1.9.19 and Ruby 1.9 support in 1.11.0
-  gem 'ffi', '< 1.9.19'
-else
-  gem 'ffi', '~> 1.11.0'
-end
-
 # No need to run rubocop on earlier versions
 if RUBY_VERSION >= '2.4' && RUBY_ENGINE == 'ruby'
   gem "rubocop", "~> 0.52.1"
 end
 
-eval File.read('Gemfile-custom') if File.exist?('Gemfile-custom')
+eval_gemfile 'Gemfile-custom' if File.exist?('Gemfile-custom')

appveyor.yml

@@ -33,9 +33,6 @@ test_script:
 
 environment:
   matrix:
-    - ruby_version: 200
-    - ruby_version: 21
-    - ruby_version: 22
     - ruby_version: 23-x64
     - ruby_version: 24-x64
     - ruby_version: 25-x64

lib/rspec/support.rb

@@ -12,22 +12,13 @@ module Support
     # hand, does a linear O(N) search over the dirs in the $LOAD_PATH until
     # it can resolve the file relative to one of the dirs.
     def self.define_optimized_require_for_rspec(lib, &require_relative)
-      name = "require_rspec_#{lib}"
-
-      if Kernel.respond_to?(:require_relative)
-        (class << self; self; end).__send__(:define_method, name) do |f|
+      define_singleton_method("require_rspec_#{lib}") do |f|
         require_relative.call("#{lib}/#{f}")
       end
-      else
-        (class << self; self; end).__send__(:define_method, name) do |f|
-          require "rspec/#{lib}/#{f}"
-        end
-      end
     end
 
     define_optimized_require_for_rspec(:support) { |f| require_relative(f) }
     require_rspec_support "version"
-    require_rspec_support "ruby_features"
 
     # @api private
     KERNEL_METHOD_METHOD = ::Kernel.instance_method(:method)
@@ -43,25 +34,8 @@ def self.define_optimized_require_for_rspec(lib, &require_relative)
     #   - BasicObject subclasses that mixin a Kernel dup (e.g. SimpleDelegator)
     #   - Objects that undefine method and delegate everything to another
     #     object (e.g. Mongoid association objects)
-    if RubyFeatures.supports_rebinding_module_methods?
-      def self.method_handle_for(object, method_name)
-        KERNEL_METHOD_METHOD.bind(object).call(method_name)
-      rescue NameError => original
-        begin
-          handle = object.method(method_name)
-          raise original unless handle.is_a? Method
-          handle
-        rescue Support::AllExceptionsExceptOnesWeMustNotRescue
-          raise original
-        end
-      end
-    else
     def self.method_handle_for(object, method_name)
-        if ::Kernel === object
       KERNEL_METHOD_METHOD.bind(object).call(method_name)
-        else
-          object.method(method_name)
-        end
     rescue NameError => original
       begin
         handle = object.method(method_name)
@@ -71,7 +45,6 @@ def self.method_handle_for(object, method_name)
         raise original
       end
     end
-    end
 
     # @api private
     #
@@ -94,7 +67,7 @@ def self.failure_notifier=(callable)
     end
 
     # @private
-    DEFAULT_FAILURE_NOTIFIER = lambda { |failure, _opts| raise failure }
+    DEFAULT_FAILURE_NOTIFIER = ->(failure, _opts) { raise failure }
 
     # @api private
     def self.failure_notifier
@@ -121,7 +94,7 @@ class << self
     end
 
     # @private
-    DEFAULT_WARNING_NOTIFIER = lambda { |warning| ::Kernel.warn warning }
+    DEFAULT_WARNING_NOTIFIER = ->(warning) { ::Kernel.warn warning }
 
     # @api private
     def self.warning_notifier

lib/rspec/support/caller_filter.rb

@@ -1,5 +1,3 @@
-RSpec::Support.require_rspec_support "ruby_features"
-
 module RSpec
   # Consistent implementation for "cleaning" the caller method to strip out
   # non-rspec lines. This enables errors to be reported at the call site in
@@ -27,7 +25,6 @@ class CallerFilter
     # with this complexity in our `RSpec.deprecate` calls, so we ignore it here.
     IGNORE_REGEX = Regexp.union(LIB_REGEX, "rubygems/core_ext/kernel_require.rb")
 
-    if RSpec::Support::RubyFeatures.caller_locations_supported?
     # This supports args because it's more efficient when the caller specifies
     # these. It allows us to skip frames the caller knows are part of RSpec,
     # and to decrease the increment size if the caller is confident the line will
@@ -72,12 +69,5 @@ def self.first_non_rspec_line(skip_frames=3, increment=5)
         increment *= 2 # The choice of two here is arbitrary.
       end
     end
-    else
-      # Earlier rubies do not support the two argument form of `caller`. This
-      # fallback is logically the same, but slower.
-      def self.first_non_rspec_line(*)
-        caller.find { |line| line !~ IGNORE_REGEX }
-      end
-    end
   end
 end

lib/rspec/support/comparable_version.rb

@@ -1,46 +1 @@
-module RSpec
-  module Support
-    # @private
-    class ComparableVersion
-      include Comparable
-
-      attr_reader :string
-
-      def initialize(string)
-        @string = string
-      end
-
-      def <=>(other) # rubocop:disable Metrics/AbcSize
-        other = self.class.new(other) unless other.is_a?(self.class)
-
-        return 0 if string == other.string
-
-        longer_segment_count = [self, other].map { |version| version.segments.count }.max
-
-        longer_segment_count.times do |index|
-          self_segment = segments[index] || 0
-          other_segment = other.segments[index] || 0
-
-          if self_segment.class == other_segment.class
-            result = self_segment <=> other_segment
-            return result unless result == 0
-          else
-            return self_segment.is_a?(String) ? -1 : 1
-          end
-        end
-
-        0
-      end
-
-      def segments
-        @segments ||= string.scan(/[a-z]+|\d+/i).map do |segment|
-          if segment =~ /\A\d+\z/
-            segment.to_i
-          else
-            segment
-          end
-        end
-      end
-    end
-  end
-end
+# FIXME: if you remove this, `double`, `hide_const`, `stub_const` can't be found in specs

lib/rspec/support/differ.rb

@@ -66,7 +66,7 @@ def color?
 
       def initialize(opts={})
         @color = opts.fetch(:color, false)
-        @object_preparer = opts.fetch(:object_preparer, lambda { |string| string })
+        @object_preparer = opts.fetch(:object_preparer, ->(string) { string })
       end
 
     private
@@ -102,15 +102,9 @@ def diffably_stringify(array)
         end
       end
 
-      if String.method_defined?(:encoding)
       def multiline?(string)
         string.include?("\n".encode(string.encoding))
       end
-      else
-        def multiline?(string)
-          string.include?("\n")
-        end
-      end
 
       def build_hunks(actual, expected)
         HunkGenerator.new(actual, expected).hunks
@@ -183,7 +177,7 @@ def object_to_string(object)
         when Array
           PP.pp(ObjectFormatter.prepare_for_inspection(object), "".dup)
         when String
-          object =~ /\n/ ? object : object.inspect
+          object.match?(/\n/) ? object : object.inspect
         else
           PP.pp(object, "".dup)
         end

lib/rspec/support/directory_maker.rb

@@ -1,5 +1,3 @@
-RSpec::Support.require_rspec_support 'ruby_features'
-
 module RSpec
   module Support
     # @api private