Skip to content

ignore.map is not a function #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whyboris opened this issue May 7, 2020 · 2 comments · Fixed by #101
Closed

ignore.map is not a function #100

whyboris opened this issue May 7, 2020 · 2 comments · Fixed by #101

Comments

@whyboris
Copy link
Contributor

whyboris commented May 7, 2020 •
edited
Loading

Currently using the --ig flag does not work:

diff2html --ig package-lock.json

results in:

TypeError: ignore.map is not a function

diff2html-cli/src/cli.ts

Line 17 in 1c9b955

const ignoreArgs = ignore.map(file => `":(exclude)${file}"`);

I've not looked into it, just reporting 😅
@whyboris
Copy link
Contributor Author

whyboris commented May 9, 2020

🎉 Looked into it, it's just a matter of updating the yargs type 😉

type: 'array',

instead of nargs: 1, this line:
https://github.com/rtfpessoa/diff2html-cli/blob/master/src/yargs.ts#L177

@whyboris whyboris mentioned this issue May 9, 2020
Merged
@rtfpessoa
Copy link
Owner

Released as version 5.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ignore yarg flag whyboris/diff2html-cli
2 participants
@rtfpessoa @whyboris