Skip to content

Dependency update? #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mensfeld opened this issue Jul 24, 2020 · 3 comments · Fixed by #105
Closed

Dependency update? #104

mensfeld opened this issue Jul 24, 2020 · 3 comments · Fixed by #105
Assignees
@rtfpessoa
Labels
dependencies Pull requests that update a dependency file enhancement

Comments

@mensfeld
Copy link

mensfeld commented Jul 24, 2020 •
edited
Loading

Hey, first of all, thank you for this amazing lib and its maintenance.

I've noticed, that the package.json locks the diff2html to 3.1.6 while there's 3.1.9 ready with some bug fixes. Is there a chance for upgrade?

It does not want to use the newer release with yarn:

diff2html-cli@^5.1.1:
  version "5.1.1"
  resolved "https://registry.yarnpkg.com/diff2html-cli/-/diff2html-cli-5.1.1.tgz#f6de2131aca5ca8190aa69f574361212f458a757"
  integrity sha512-toCl99MHN1+jErcwys0DEcDGhF8DDO9C2/WGYQK44oCEKCiTVBKEOD6UJJc7TVL4fYR+zqiH7UZDUiPgH/qD4Q==
  dependencies:
    clipboardy "^2.3.0"
    diff2html "3.1.6"
    node-fetch "^2.6.0"
    open "^7.0.3"
    yargs "^15.3.1"
@rtfpessoa rtfpessoa mentioned this issue Jul 24, 2020
Merged
@rtfpessoa rtfpessoa self-assigned this Jul 24, 2020
@rtfpessoa rtfpessoa added dependencies Pull requests that update a dependency file enhancement labels Jul 24, 2020
@rtfpessoa
Copy link
Owner

Released as version 5.1.2

@mensfeld
Copy link
Author

Woooooo that was quick. Thank you sooooooo much! You are amazing (seriously)!

@rtfpessoa
Copy link
Owner

I was planning to do some maintenance and since you remembered me I just did it immediatly 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtfpessoa rtfpessoa

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump: Bump dependencies rtfpessoa/diff2html-cli
2 participants
@mensfeld @rtfpessoa