Skip to content

Commit 09cc530

Browse files
balajisankar15Balaji Sankar
authored andcommitted
Fix: Certain unit tests aren't passing sagemaker_session. Modify the logic to accommodate that case (aws#850)
Co-authored-by: Balaji Sankar <[email protected]>
1 parent 29c9728 commit 09cc530

File tree

1 file changed

+21
-7
lines changed

1 file changed

+21
-7
lines changed

src/sagemaker/pipeline.py

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,29 @@ def __init__(
9191
self.name = name
9292
self.sagemaker_session = sagemaker_session
9393
self.endpoint_name = None
94-
self.role = self.sagemaker_session.get_sagemaker_config_override(
95-
MODEL_EXECUTION_ROLE_ARN_PATH, default_value=role
94+
self.role = (
95+
self.sagemaker_session.get_sagemaker_config_override(
96+
MODEL_EXECUTION_ROLE_ARN_PATH, default_value=role
97+
)
98+
if sagemaker_session
99+
else role
100+
)
101+
self.vpc_config = (
102+
self.sagemaker_session.get_sagemaker_config_override(
103+
MODEL_VPC_CONFIG_PATH, default_value=vpc_config
104+
)
105+
if sagemaker_session
106+
else vpc_config
96107
)
97-
self.vpc_config = self.sagemaker_session.get_sagemaker_config_override(
98-
MODEL_VPC_CONFIG_PATH, default_value=vpc_config
108+
default_enable_network_isolation = (
109+
False if enable_network_isolation is None else enable_network_isolation
99110
)
100-
self.enable_network_isolation = self.sagemaker_session.get_sagemaker_config_override(
101-
MODEL_ENABLE_NETWORK_ISOLATION_PATH,
102-
default_value=False if enable_network_isolation is None else enable_network_isolation,
111+
self.enable_network_isolation = (
112+
self.sagemaker_session.get_sagemaker_config_override(
113+
MODEL_ENABLE_NETWORK_ISOLATION_PATH, default_value=default_enable_network_isolation
114+
)
115+
if sagemaker_session
116+
else default_enable_network_isolation
103117
)
104118
if not self.role:
105119
# Originally IAM role was a required parameter.

0 commit comments

Comments
 (0)