Skip to content

Commit 3ab8924

Browse files
committed
Move dev dependencies to Gemfile
A similar (unmerged) `rspec-support` PR rspec/rspec-support#517 Reasoning (https://bundler.io/v2.2/man/gemfile.5.html#GEMSPEC): > The .gemspec file is ... where you specify the dependencies your gem needs *to run*. Even though it contradicts the very existence of add_development_dependency. Discussions: - rubygems/rubygems#5065 - rubygems/rubygems#1104
1 parent 0227e6e commit 3ab8924

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Gemfile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ source 'https://rubygems.org'
44

55
gemspec
66

7+
gem 'rack'
8+
gem 'rake'
9+
gem 'rspec', '>= 3.4'
10+
gem 'rubocop-performance', '~> 1.7'
11+
gem 'rubocop-rake', '~> 0.6'
12+
gem 'yard'
13+
714
local_gemfile = 'Gemfile.local'
815

916
if File.exist?(local_gemfile)

rubocop-rspec.gemspec

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,4 @@ Gem::Specification.new do |spec|
3838
}
3939

4040
spec.add_runtime_dependency 'rubocop', '~> 1.31'
41-
42-
spec.add_development_dependency 'rack'
43-
spec.add_development_dependency 'rake'
44-
spec.add_development_dependency 'rspec', '>= 3.4'
45-
spec.add_development_dependency 'rubocop-performance', '~> 1.7'
46-
spec.add_development_dependency 'rubocop-rake', '~> 0.6'
47-
spec.add_development_dependency 'yard'
4841
end

0 commit comments

Comments
 (0)