Add new for AllowAdjacentOneLineHooks option for Rspec/EmptyLineAfterHook

Author: ngouy

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+* Add new `AllowConsecutiveOneLiners` (default true) option for `Rspec/EmptyLineAfterHook` cop. ([@ngouy][])
+
 ## 2.12.1 (2022-07-03)
 
 * Fix a false positive for `RSpec/Capybara/SpecificMatcher`. ([@ydah][])

config/default.yml

@@ -315,8 +315,10 @@ RSpec/EmptyLineAfterHook:
   Description: Checks if there is an empty line after hook blocks.
   Enabled: true
   VersionAdded: '1.27'
+  VersionChanged: '2.13'
   StyleGuide: https://rspec.rubystyle.guide/#empty-line-after-let
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterHook
+  AllowConsecutiveOneLiners: true
 
 RSpec/EmptyLineAfterSubject:
   Description: Checks if there is an empty line after subject block.

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -1123,11 +1123,14 @@ it { does_something }
 | Yes
 | Yes
 | 1.27
-| -
+| 2.13
 |===
 
 Checks if there is an empty line after hook blocks.
 
+`AllowConsecutiveOneLiners` configures whether adjacent
+one-line definitions are considered an offense.
+
 === Examples
 
 [source,ruby]
@@ -1145,21 +1148,49 @@ around { |test| test.run }
 it { does_something }
 
 # good
-before { do_something }
+after { do_something }
 
 it { does_something }
 
-# good
+# fair - it's ok to have non-separated one-liners hooks
+around { |test| test.run }
+after { do_something }
+
+it { does_something }
+----
+
+==== with AllowConsecutiveOneLiners configuration
+
+[source,ruby]
+----
+# rubocop.yml
+# RSpec/EmptyLineAfterHook:
+#   AllowConsecutiveOneLiners: false
+
+# bad
+around { |test| test.run }
 after { do_something }
 
 it { does_something }
 
 # good
 around { |test| test.run }
 
+after { do_something }
+
 it { does_something }
 ----
 
+=== Configurable attributes
+
+|===
+| Name | Default value | Configurable values
+
+| AllowConsecutiveOneLiners
+| `true`
+| Boolean
+|===
+
 === References
 
 * https://rspec.rubystyle.guide/#empty-line-after-let

lib/rubocop/cop/rspec/empty_line_after_hook.rb

@@ -5,6 +5,9 @@ module Cop
     module RSpec
       # Checks if there is an empty line after hook blocks.
       #
+      # `AllowConsecutiveOneLiners` configures whether adjacent
+      # one-line definitions are considered an offense.
+      #
       # @example
       #   # bad
       #   before { do_something }
@@ -19,33 +22,57 @@ module RSpec
       #   it { does_something }
       #
       #   # good
-      #   before { do_something }
+      #   after { do_something }
       #
       #   it { does_something }
       #
-      #   # good
+      #   # fair - it's ok to have non-separated one-liners hooks
+      #   around { |test| test.run }
       #   after { do_something }
       #
       #   it { does_something }
       #
-      #   # good
+      # @example with AllowConsecutiveOneLiners configuration
+      #   # rubocop.yml
+      #   # RSpec/EmptyLineAfterHook:
+      #   #   AllowConsecutiveOneLiners: false
+      #
+      #   # bad
       #   around { |test| test.run }
+      #   after { do_something }
       #
       #   it { does_something }
       #
+      #   # good
+      #   around { |test| test.run }
+      #
+      #   after { do_something }
+      #
+      #   it { does_something }
       class EmptyLineAfterHook < Base
         extend AutoCorrector
+        include ConfigurableEnforcedStyle
         include EmptyLineSeparation
 
         MSG = 'Add an empty line after `%<hook>s`.'
 
         def on_block(node)
           return unless hook?(node)
+          return if cop_config['AllowConsecutiveOneLiners'] &&
+            chained_single_line_hooks?(node)
 
           missing_separating_line_offense(node) do |method|
             format(MSG, hook: method)
           end
         end
+
+        private
+
+        def chained_single_line_hooks?(node)
+          next_node = node.right_sibling
+
+          hook?(next_node) && node.single_line? && next_node.single_line?
+        end
       end
     end
   end