Skip to content

Commit b0bf551

Browse files
committed
obscure auth password upon #inspect, added test, closes #216
1 parent e7fde22 commit b0bf551

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

lib/net/ldap.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1195,6 +1195,11 @@ def paged_searches_supported?
11951195
@server_caps[:supportedcontrol].include?(Net::LDAP::LDAPControls::PAGED_RESULTS)
11961196
end
11971197

1198+
# Mask auth password
1199+
def inspect
1200+
super.gsub @auth[:password], "*******" if @auth[:password]
1201+
end
1202+
11981203
private
11991204

12001205
# Yields an open connection if there is one, otherwise establishes a new

test/test_ldap.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,10 @@ def test_instrument_search_with_size
5757
assert_equal "(uid=user1)", payload[:filter]
5858
assert_equal result.size, payload[:size]
5959
end
60+
61+
def test_obscure_auth
62+
password = "opensesame"
63+
@subject.auth "joe_user", password
64+
assert_not_include(@subject.inspect, password)
65+
end
6066
end

0 commit comments

Comments
 (0)