Rebase #168: Connection#unescape handles numerics, #search guards against nil queued_reads #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Connection#search now does more graceful nil-checking in its ensure clause, reducing cryptic crash messages * Filter class methods should now be able to gracefully accept numeric literals as filter rhs values
…' into rebase-168-nil-guard-numeric-unescape
Closed
| # clean up message queue for this search | ||
| messages = message_queue.delete(message_id) | ||
|
|
||
| # in the exceptional case some messages were *not* consumed from the queue, | ||
| # instrument the event but do not fail. | ||
| unless messages.empty? | ||
| if !messages.nil? && !messages.empty? |
|
Looks good! |
jch
added a commit
that referenced
this pull request
Jan 8, 2015
…nescape Rebase #168: Connection#unescape handles numerics, #search guards against nil queued_reads
Merged
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
…numeric-unescape Rebase ruby-ldap#168: Connection#unescape handles numerics, #search guards against nil queued_reads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #168 for background and feedback.