Implement '==' operator for entries

[erlliam]

Hey @HarlemSquirrel I was going through your profile and saw this repository. This issue seemed like something I could solve.

Resolves #372

[esparta]

Suggested change

	return @myhash == other.to_h
	@myhash == other.to_h

Also, should this method check if the other is the same class?

[erlliam]

Should the equal operator work for sub classes of entries ? I was going to write other.class == self.class instead of instance_of?, but I felt like the latter is probably the better choice. Is there any difference between those two?

[HarlemSquirrel]

While we don't really have an exposed way to create objects that inherit from Net::LDAP::Entry I would say those would be OK to consider equal as far as Class goes. For Ruby Hash objects == Returns true if all of the following are true:

• object is a Hash object.
• hash and object have the same keys (regardless of order).
• For each key key, hash[key] == object[key].

[HarlemSquirrel]

@erlliam other.class == self.class and other.instance_of?(self.class) are doing essentially the same thing. The late does feel more to the spirit of Ruby where we often prefer what sounds or looks more "natural".

[HarlemSquirrel]

Nice work!