Allow formatting code with a different base level of indentation #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to override the base level of indentation allows us to format parts of a document that may be nested. This will allow the Ruby LSP to implement range formatting.
For example,
The necessary changes in prettier print are here ruby-syntax-tree/prettier_print#4.
Concerns
Currently, the implementation adds the new base indentation to the last new line of the formatted source. For example,
I'm not sure if this is coming from Syntax Tree or prettier print. This is why we currently have the
rstrip
in the tests.